[Bugfix] Fix 1-indexing for replica_id in MetricsStore #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nitinkedia7 can you please take a look, thanks! |
|
@sicario001 Please look at the comments I have left and also accept the Contributor License Agreement (without which the PR cannot be merged). |
|
@microsoft-github-policy-service agree |
|
@sicario001 @nitinkedia7 are we good to merge? |
nitinkedia7
requested changes
Sep 17, 2024
| @@ -699,9 +698,9 @@ def on_replica_stage_schedule( | |||
| if not self._config.store_utilization_metrics: | |||
| return | |||
|
|
|||
| self._replica_busy_time[replica_id - 1][stage_id - 1].put(time, 100) | |||
| self._replica_busy_time[replica_id][stage_id - 1].put(time, 100) | |||
There was a problem hiding this comment.
Can we align statge_id also along with replica_id to be 0-indexed? This will help in uniformity.
There was a problem hiding this comment.
Also while printing the metrics in _store_utilization_metrics we can remove the + 1 from the plot names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
MetricsStoreuses 1-indexing forreplica_idat several places even thoughreplica_ids are 0-indexed.Fix
Update 1-indexed usage of
replica_idin_replica_memory_usage,_replica_busy_timeand_replica_mfuinsideMetricsStoreto 0-indexed.