Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Type checking for config #40

Merged

Conversation

anmolagarwalcp810
Copy link
Contributor

@anmolagarwalcp810 anmolagarwalcp810 commented Oct 8, 2024

Earlier when invalid config type was passed, vidur resorted to default config without throwing any error, and this led to wrong configuration being passed in for the simulator.

FIX:
We do a check on config type match. If config type does not match then we throw an error to prevent vidur from resorting to default configuration.


PR Checklist (Click to Expand)

Thank you for your contribution to Vidur! Before submitting the pull request, please ensure the PR meets the following criteria. This helps Vidur maintain the code quality and improve the efficiency of the review process.

PR Title and Classification

Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:

  • [Bugfix] for bug fixes.
  • [CI/Build] for build or continuous integration improvements.
  • [Doc] for documentation fixes and improvements.
  • [Model] for adding a new model or improving an existing model. Model name should appear in the title.
  • [Profiling] For changes on the profiling module.
  • [Core] for changes in the core simulator logic
  • [Misc] for PRs that do not fit the above categories. Please use this sparingly.

Note: If the PR spans more than one category, please include all relevant prefixes.

Code Quality

The PR need to meet the following code quality standards:

  • Pass all linter checks. Please use make format to format your code.
  • The code need to be well-documented to ensure future contributors can easily understand the code.
  • Please add documentation to docs/source/ if the PR modifies the user-facing behaviors of Vidur. It helps user understand and utilize the new features or changes.

Notes for Large Changes

Please keep the changes as concise as possible. For major architectural changes (>500 LOC), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with rfc-required and might not go through the PR.

Thank You

Finally, thank you for taking the time to read these guidelines and for your interest in contributing to Vidur. Your contributions make Vidur a great tool for everyone!

@nitinkedia7 nitinkedia7 self-requested a review October 10, 2024 07:22
@nitinkedia7 nitinkedia7 merged commit 33100ba into microsoft:main Oct 10, 2024
2 checks passed
Hanchenli pushed a commit to XbzOnGit/vidur that referenced this pull request Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants