Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The compiler path selection control is not in sync with the textbox #12678

Merged
merged 4 commits into from
Sep 4, 2024

Conversation

bobbrow
Copy link
Member

@bobbrow bobbrow commented Sep 3, 2024

Fixes: #7427

The faux editable combobox we use to set the compilerPath property was not keeping the select control in sync with the contents of the textbox. This change fixes it.

@bobbrow
Copy link
Member Author

bobbrow commented Sep 3, 2024

Suddenly it doesn't compile. I'm investigating why. It has to do with importing path.normalize which didn't repro when I was testing, but now it does. :(

@bobbrow bobbrow marked this pull request as draft September 3, 2024 23:28
@bobbrow bobbrow marked this pull request as ready for review September 3, 2024 23:35
Extension/ui/settings.ts Show resolved Hide resolved
Extension/ui/settings.ts Outdated Show resolved Hide resolved
@bobbrow bobbrow merged commit 7006e18 into main Sep 4, 2024
6 checks passed
@bobbrow bobbrow deleted the bobbrow/compilerPathSync branch September 4, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

The compilerPath option does not match the tick in front of the option in the drop-down box (Mac OS only)
2 participants