Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show the reload window message when caseSensitiveFileSupport is changed. #12700

Merged
merged 4 commits into from
Sep 13, 2024
Merged

Show the reload window message when caseSensitiveFileSupport is changed. #12700

merged 4 commits into from
Sep 13, 2024

Conversation

sean-mcmanus
Copy link
Contributor

Fixes #12699

@sean-mcmanus sean-mcmanus requested a review from a team September 10, 2024 21:34
Colengms
Colengms requested changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@Colengms Colengms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to trigger the prompt entirely on the TypeScript side? Seems odd to plumb up a bool to the native side for the purpose of sending a message back down to the TypeScript code to call promptForReloadWindowDueToSettingsChange.

@sean-mcmanus
Copy link
Contributor Author

Would it be possible to trigger the prompt entirely on the TypeScript side? Seems odd to plumb up a bool to the native side for the purpose of sending a message back down to the TypeScript code to call promptForReloadWindowDueToSettingsChange.

Yeah, maybe -- I was just following the previous example with experimentalFeatures. I'm not sure why that case also wasn't handled all on the TypeScript side too.

@sean-mcmanus sean-mcmanus merged commit 50e0f86 into main Sep 13, 2024
6 checks passed
@sean-mcmanus sean-mcmanus deleted the seanmcm/showReloadWindowCaseSensitiveFileSupport branch September 13, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Colengms Colengms Colengms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
cpptools
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No reload window message is shown after the C_Cpp.caseSensitiveFileSupport is changed (on Windows)
2 participants
@sean-mcmanus @Colengms