Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge to vs #12731

Merged
merged 26 commits into from
Sep 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
fbfddd2
Prevent AddComment action from adding redundant comments (#12611)
Colengms Aug 21, 2024
326f7d9
Spread out schedules of github actions to avoid 'rate limit' errors (…
Colengms Aug 23, 2024
d8a6a98
Switch from LSP hover to HoverProvider (#12612)
Colengms Aug 23, 2024
d3cd4fc
Fix vcFormat not working and other case comparison bugs. (#12620)
sean-mcmanus Aug 23, 2024
e5ce40b
Log the modified extension settings as part of Log Diagnostics (#12621)
bobbrow Aug 26, 2024
c81120e
Bump micromatch from 4.0.7 to 4.0.8 in /Extension (#12630)
dependabot[bot] Aug 26, 2024
49d987d
Fix show a list local processes, if remote connection failed (useExte…
MrStanislav0 Aug 26, 2024
3dc7067
Update changelog (2nd time) (#12631)
sean-mcmanus Aug 26, 2024
994e7b9
Log the values of editor settings that we track (#12635)
bobbrow Aug 28, 2024
1f426ed
Address a component governance report on webpack (#12649)
bobbrow Aug 28, 2024
f222a97
Update changelog for 1.22.1 (#12646)
sean-mcmanus Aug 29, 2024
fcdccd4
Remove usage of intellisenseEngineFallback setting. (#12600)
browntarik Aug 29, 2024
b7f76c5
Remove intellisenseEngineFallback description (#12655)
browntarik Aug 30, 2024
86b698b
Update changelog and version for 1.22.2. (#12657)
sean-mcmanus Aug 30, 2024
93a20bc
Update link to glob info (#12671)
bobbrow Aug 31, 2024
f077665
delete configuration properties when empty (#12670)
bobbrow Sep 4, 2024
7006e18
The compiler path selection control is not in sync with the textbox (…
bobbrow Sep 4, 2024
8111083
remove old loc files for TS files that don't exist anymore (#12686)
bobbrow Sep 5, 2024
8718b96
Fix extract to function formatting. (#12679)
sean-mcmanus Sep 6, 2024
731cccd
Add C++ configuration as a language model tool (luca) (#12685)
lukka Sep 6, 2024
44671aa
Update checkDTS() to be aware of lmTools (#12696)
benmcmorran Sep 9, 2024
fc5a084
Update changelog and version for 1.22.3 (#12703)
Colengms Sep 12, 2024
50e0f86
Show the reload window message when caseSensitiveFileSupport is chang…
sean-mcmanus Sep 13, 2024
ccc07f5
Enable log diagnostics without a C/C++ file active. (#12701)
sean-mcmanus Sep 13, 2024
cd4ef23
Update changelog. (#12710)
sean-mcmanus Sep 13, 2024
970f95b
Update IntelliSense loc strings. (#12726)
sean-mcmanus Sep 18, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions .github/actions/AddComment/AddComment.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

19 changes: 18 additions & 1 deletion .github/actions/AddComment/AddComment.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import { daysAgoToHumanReadbleDate, daysAgoToTimestamp, safeLog } from '../commo
export class AddComment extends ActionBase {
constructor(
private github: GitHub,
private createdAfter: string,
private createdAfter: string | undefined,
private afterDays: number,
labels: string,
private addComment: string,
Expand Down Expand Up @@ -45,6 +45,23 @@ export class AddComment extends ActionBase {
if (hydrated.open && this.validateIssue(hydrated)
// TODO: Verify updated timestamp
) {
// Don't add a comment if already commented on by an action.
let foundActionComment = false;
for await (const commentBatch of issue.getComments()) {
for (const comment of commentBatch) {
if (comment.author.isGitHubApp) {
foundActionComment = true;
break;
}
}
if (foundActionComment)
break;
}
if (foundActionComment) {
safeLog(`Issue ${hydrated.number} already commented on by an action. Ignoring.`);
continue;
}

if (this.addComment) {
safeLog(`Posting comment on issue ${hydrated.number}`);
await issue.postComment(this.addComment);
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/bug-debugger.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: Bug - debugger
on:
schedule:
- cron: 20 11 * * * # Run at 11:20 AM UTC (3:20 AM PST, 4:20 AM PDT)
- cron: 50 12 * * * # Run at 12:50 PM UTC (4:50 AM PST, 5:50 AM PDT)
workflow_dispatch:
inputs:
readonly:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/by-design-closer-debugger .yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: By Design closer - debugger
on:
schedule:
- cron: 10 11 * * * # Run at 11:10 AM UTC (3:10 AM PST, 4:10 AM PDT)
- cron: 0 13 * * * # Run at 1:00 PM UTC (5:00 AM PST, 6:00 AM PDT)
workflow_dispatch:
inputs:
readonly:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/enhancement-closer-no-milestone.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: Enhancement Closer (no milestone)
on:
schedule:
- cron: 50 11 * * * # Run at 11:50 AM UTC (3:50 AM PST, 4:50 AM PDT)
- cron: 40 12 * * * # Run at 12:40 PM UTC (4:40 AM PST, 5:40 AM PDT)
workflow_dispatch:
inputs:
readonly:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/enhancement-closer-triage.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: Enhancement Closer (Triage)
on:
schedule:
- cron: 40 11 * * * # Run at 11:40 AM UTC (3:40 AM PST, 4:40 AM PDT)
- cron: 30 12 * * * # Run at 12:30 PM UTC (4:30 AM PST, 5:30 AM PDT)
workflow_dispatch:
inputs:
readonly:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/enhancement-reopener.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: Enhancement Reopener
on:
schedule:
- cron: 20 12 * * * # Run at 12:20 PM UTC (4:20 AM PST, 5:20 AM PDT)
- cron: 0 11 * * * # Run at 11:00 AM UTC (3:00 AM PST, 4:00 AM PDT)
workflow_dispatch:
inputs:
readonly:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/external-closer-debugger.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: External closer - debugger
on:
schedule:
- cron: 10 11 * * * # Run at 11:10 AM UTC (3:10 AM PST, 4:10 AM PDT)
- cron: 10 13 * * * # Run at 1:10 PM UTC (5:10 AM PST, 6:10 AM PDT)
workflow_dispatch:
inputs:
readonly:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/feature-request-debugger.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: Feature Request - debugger
on:
schedule:
- cron: 20 11 * * * # Run at 11:20 AM UTC (3:20 AM PST, 4:20 AM PDT)
- cron: 20 13 * * * # Run at 1:20 PM UTC (5:20 AM PST, 6:20 AM PDT)
workflow_dispatch:
inputs:
readonly:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/investigate-closer-debugger.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: Investigate closer - debugger
on:
schedule:
- cron: 10 11 * * * # Run at 11:10 AM UTC (3:10 AM PST, 4:10 AM PDT)
- cron: 30 13 * * * # Run at 1:30 PM UTC (5:30 AM PST, 6:30 AM PDT)
workflow_dispatch:
inputs:
readonly:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/investigate-costing-closer-debugger.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: Investigate Costing closer - debugger
on:
schedule:
- cron: 10 11 * * * # Run at 11:10 AM UTC (3:10 AM PST, 4:10 AM PDT)
- cron: 40 13 * * * # Run at 1:40 PM UTC (5:40 AM PST, 6:40 AM PDT)
workflow_dispatch:
inputs:
readonly:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/more-info-needed-closer-debugger.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: More Info Needed Closer - debugger
on:
schedule:
- cron: 10 11 * * * # Run at 11:10 AM UTC (3:10 AM PST, 4:10 AM PDT)
- cron: 50 13 * * * # Run at 1:50 PM UTC (5:50 AM PST, 6:50 AM PDT)
workflow_dispatch:
inputs:
readonly:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/question-closer-debugger.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: Question Closer - debugger
on:
schedule:
- cron: 20 11 * * * # Run at 11:20 AM UTC (3:20 AM PST, 4:20 AM PDT)
- cron: 0 14 * * * # Run at 2:00 PM UTC (6:00 AM PST, 7:00 AM PDT)
workflow_dispatch:
inputs:
readonly:
Expand Down
1 change: 1 addition & 0 deletions Extension/.scripts/common.ts
Original file line number Diff line number Diff line change
Expand Up @@ -325,6 +325,7 @@ export async function checkDTS() {
let failing = false;
failing = !await assertAnyFile('vscode.d.ts') && (quiet || warn(`The VSCode import file '${$root}/dist/src/vscode.d.ts is missing.`)) || failing;
failing = !await assertAnyFile('vscode.proposed.terminalDataWriteEvent.d.ts') && (quiet || warn(`The VSCode import file '${$root}/dist/src/vscode.proposed.terminalDataWriteEvent.d.ts is missing.`)) || failing;
failing = !await assertAnyFile('vscode.proposed.lmTools.d.ts') && (quiet || warn(`The VSCode import file '${$root}/dist/src/vscode.proposed.lmTools.d.ts is missing.`)) || failing;

if (!failing) {
verbose('VSCode d.ts files appear to be in place.');
Expand Down
2 changes: 1 addition & 1 deletion Extension/.vscode/settings.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
},
"[typescript]": {
"editor.tabSize": 4,
"editor.defaultFormatter": "dbaeumer.vscode-eslint",
"editor.defaultFormatter": "vscode.typescript-language-features",
"editor.formatOnSave": true,
"files.insertFinalNewline": true,
"editor.codeActionsOnSave": {
Expand Down
43 changes: 41 additions & 2 deletions Extension/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,16 +1,52 @@
# C/C++ for Visual Studio Code Changelog

## Version 1.22.0: August 21, 2024
## Version 1.22.3: September 12, 2024
### Enhancement
* Add support for providing additional context information to Copilot Chat. [PR #12685](https://github.com/microsoft/vscode-cpptools/pull/12685)
* Currently, it requires `"C_Cpp.experimentalFeatures": "enabled"` and typing `#cpp` in the chat.

### Bug Fixes
* Fix the compiler selection control not keeping the list in sync with contents of the textbox. [#7427](https://github.com/microsoft/vscode-cpptools/issues/7427)
* Fix a string localization issue. [#7824](https://github.com/microsoft/vscode-cpptools/issues/7824)
* Stop logging duplicate compiler path messages. [#12445](https://github.com/microsoft/vscode-cpptools/issues/12445)
* Fix some crashes with recursive includes. [#12643](https://github.com/microsoft/vscode-cpptools/issues/12643)
* Fix a rare crash on macOS related to `get_memory_usage`. [#12667](https://github.com/microsoft/vscode-cpptools/issues/12667)
* Fix an issue with 'Extract to Function' formatting. [#12677](https://github.com/microsoft/vscode-cpptools/issues/12677)
* Fix a potential deadlock in `process_paths`. [#12690](https://github.com/microsoft/vscode-cpptools/issues/12690)

## Version 1.22.2: August 29, 2024
### Enhancement
* Remove the `C_Cpp.intelliSenseEngineFallback` setting. [#12596](https://github.com/microsoft/vscode-cpptools/issues/12596)

### Bug Fix
* Fix a deadlock when doing "Find All References" and a file is deleted. [#12656](https://github.com/microsoft/vscode-cpptools/issues/12656)

## Version 1.22.1: August 29, 2024
### Enhancement
* Add "Additional Tracked Settings" to `C/C++: Log Diagnostics` output. [PR #12635](https://github.com/microsoft/vscode-cpptools/pull/12635)

### Bug Fixes
* Fix hover over static constexpr variables sometimes not working. [#12284](https://github.com/microsoft/vscode-cpptools/issues/12284)
* Fix completion not giving results in several scenarios. [#12412](https://github.com/microsoft/vscode-cpptools/issues/12412)
* Fix include completion showing results for deleted folders with recursive includes. [#12636](https://github.com/microsoft/vscode-cpptools/issues/12636)
* Fix the `/FU` flag not working for C++/CLI . [#12641](https://github.com/microsoft/vscode-cpptools/issues/12641)
* Fix some crashes with recursive includes. [#12643](https://github.com/microsoft/vscode-cpptools/issues/12643)
* Fix IntelliSense not working on Windows when `C_Cpp.caseSensitiveFileSupport` is `enabled`. [#12648](https://github.com/microsoft/vscode-cpptools/issues/12648)
* Changes that might fix a crash with `translate_encoding_to_utf8`. [#12652](https://github.com/microsoft/vscode-cpptools/issues/12652)
* Fix a random crash during IntelliSense creation.

## Version 1.22.0: August 26, 2024
### Performance Improvements
* Switch to an alternative implementation of recursive includes (that sends all the paths instead of only the "used" paths). [#11780](https://github.com/microsoft/vscode-cpptools/issues/11780)
- Performance improvement: Configuration is no longer blocked on tag parsing of all dependent headers.
- Configuration change: Recursive include paths now always take precedence over system include paths (similar to compiler behavior and non-recursive includes). [#11485](https://github.com/microsoft/vscode-cpptools/issues/11485)
- Configuration change: Recursive include paths now take precedence over system include paths (similar to compiler behavior and non-recursive includes). [#11485](https://github.com/microsoft/vscode-cpptools/issues/11485)
* Initialization performance improvements. [#12030](https://github.com/microsoft/vscode-cpptools/issues/12030)
- Some processing is parallelized and started earlier (populating the filename cache, discovering files). [#11954](https://github.com/microsoft/vscode-cpptools/issues/11954), [#12169](https://github.com/microsoft/vscode-cpptools/issues/12169)
- Some compiler configuration queries are cached in the database, and processing of compile_commands.json was improved. [#10029](https://github.com/microsoft/vscode-cpptools/issues/10029), [#12078](https://github.com/microsoft/vscode-cpptools/issues/12078)
* Improve the implementation of file buffers to reduce memory usage.

### Enhancements
* Add modified `C_Cpp` settings to the `C/C++: Log Diagnostics` output. [#11700](https://github.com/microsoft/vscode-cpptools/issues/11700)
* Change the default C/C++ `"editor.stickyScroll.defaultModel"` to `"foldingProviderModel"`. [#12483](https://github.com/microsoft/vscode-cpptools/issues/12483)
* Add better validation for settings. [#12371](https://github.com/microsoft/vscode-cpptools/issues/12371)
* Various IntelliSense parsing updates/fixes.
Expand All @@ -20,13 +56,16 @@
* Fix an issue where a file is incorrectly processed as C instead of C++. [#12466](https://github.com/microsoft/vscode-cpptools/issues/12466)
* Fix include path ordering being incorrect if there is a duplicate. [#12525](https://github.com/microsoft/vscode-cpptools/issues/12525)
* Fix a WebAssembly "Out of Memory" error. [#12529](https://github.com/microsoft/vscode-cpptools/issues/12529)
* Fix an error message not being shown if the connection failed with remote attach debugging. [#12547](https://github.com/microsoft/vscode-cpptools/issues/12547)
* Thank you for the contribution. [@MrStanislav0 (Stanislav)](https://github.com/MrStanislav0)
* Fix `-I` not being used if `-iquote` is also used for the same path. [#12551](https://github.com/microsoft/vscode-cpptools/issues/12551)
* Fix issues with relative paths on `nvcc` (CUDA) command lines not being handled correctly. [#12553](https://github.com/microsoft/vscode-cpptools/issues/12553)
* Fix a random crash when a child process is created. [#12585](https://github.com/microsoft/vscode-cpptools/issues/12585)
* Fix a crash on shutdown on macOS with a verbose logging level. [#12567](https://github.com/microsoft/vscode-cpptools/issues/12567)
* Fix some issues with recursive includes handling of symbolic links, multi-root, exclusion changes, and file/folder deletion.
* Fix unnecessary IntelliSense resetting when a new file or folder was created.
* Fix accumulation of stale signature help and completion requests.
* Fix some bugs with include completion.

## Version 1.21.6: August 5, 2024
* Fix a cpptools-srv crash on shutdown. [#12354](https://github.com/microsoft/vscode-cpptools/issues/12354)
Expand Down
12 changes: 6 additions & 6 deletions Extension/bin/messages/cs/messages.json
Original file line number Diff line number Diff line change
Expand Up @@ -1410,7 +1410,7 @@
"Striktní režim je nekompatibilní se zpracováním oboru názvů std jako aliasu pro globální obor názvů.",
"v rozšíření makra %s %p",
"<NEZNÁMÝ>",
"",
null,
"[rozšíření makra %d není zobrazené]",
"v rozšíření makra v %p",
"neplatný název symbolického operandu %sq",
Expand Down Expand Up @@ -1505,7 +1505,7 @@
"Chyba příkazového řádku",
"vnitřní chyba",
"Vnitřní chyba",
null,
"-D",
null,
"Došlo k dosažení limitu chyb.",
"Smyčka interní chyby",
Expand All @@ -1524,7 +1524,7 @@
"převodní jazyk (7)",
"převodní jazyk (8)",
"převodní jazyk (9)",
null,
"PCH",
null,
null,
null,
Expand All @@ -1537,7 +1537,7 @@
"neplatný znak pro literál char16_t",
null,
"Nerozpoznaná konvence volání %s, musí být jednou z:",
null,
"%s",
null,
null,
"Nadřízený typ typu výčtu musí být integrální typ.",
Expand Down Expand Up @@ -2953,9 +2953,9 @@
"Neplatná hodnota sady pragma %s pro funkci s omezením AMP",
"Překrývající se specifikátory omezení nejsou povolené.",
"Specifikátory omezení destruktoru musejí pokrývat sjednocení specifikátorů omezení všech konstruktorů.",
"<error>",
"error",
"Pro nostdlib se vyžaduje aspoň jedno nucené použití.",
"<error-type>",
"error-type",
null,
null,
null,
Expand Down
12 changes: 6 additions & 6 deletions Extension/bin/messages/de/messages.json
Original file line number Diff line number Diff line change
Expand Up @@ -1410,7 +1410,7 @@
"Der Strict-Modus ist mit dem Behandeln des Namespaces \"std\" als Alias für den globalen Namespace inkompatibel.",
"In Erweiterung von Makro \"%s\" %p",
"<UNBEKANNT>",
"",
null,
"[%d Makroerweiterungen werden nicht angezeigt.]",
"In Makroerweiterung bei %p",
"Ungültiger symbolischer Operandname \"%sq\".",
Expand Down Expand Up @@ -1505,7 +1505,7 @@
"Befehlszeilenfehler",
"Interner Fehler.",
"Interner Fehler.",
null,
"-D",
null,
"Fehlerlimit erreicht.",
"Interne Fehlerschleife",
Expand All @@ -1524,7 +1524,7 @@
"Zwischensprache (7)",
"Zwischensprache (8)",
"Zwischensprache (9)",
null,
"PCH",
null,
null,
null,
Expand All @@ -1537,7 +1537,7 @@
"Ungültiges Zeichen für char16_t-Literal.",
null,
"Unbekannte Aufrufkonvention \"%s\", muss eine der folgenden Optionen sein:",
null,
"%s",
null,
null,
"Der zugrunde liegende Typ des Enumerationstyps muss ein integraler Typ sein.",
Expand Down Expand Up @@ -2953,9 +2953,9 @@
"Unzulässiger Wert für Pragmapaket \"%s\" für die auf AMP begrenzte Funktion.",
"Überlappende Einschränkungsspezifizierer sind unzulässig.",
"Die Einschränkungsspezifizierer des Destruktors müssen die Union der Einschränkungsspezifizierer für alle Konstruktoren abdecken.",
"<error>",
"Fehler",
"Für \"nostdlib\" ist mindestens eine erzwungene Verwendung erforderlich.",
"<error-type>",
"Fehlertyp",
null,
null,
null,
Expand Down
12 changes: 6 additions & 6 deletions Extension/bin/messages/es/messages.json
Original file line number Diff line number Diff line change
Expand Up @@ -1410,7 +1410,7 @@
"el modo strict no es compatible con el trato del espacio de nombres std como alias para el espacio de nombres global",
"en la expansión de macro '%s' %p,",
"<DESCONOCIDO>",
"",
null,
"[ las expansiones de macro %d no se muestran ]",
"en expansión de macro en %p",
"nombre de operando simbólico %sq no válido",
Expand Down Expand Up @@ -1505,7 +1505,7 @@
"Error de la línea de comandos",
"Error interno",
"Error interno",
null,
"-D",
null,
"Se ha alcanzado el límite de error.",
"Bucle de error interno",
Expand All @@ -1524,7 +1524,7 @@
"lenguaje intermedio (7)",
"lenguaje intermedio (8)",
"lenguaje intermedio (9)",
null,
"PCH",
null,
null,
null,
Expand All @@ -1537,7 +1537,7 @@
"carácter no válido para el literal char16_t",
null,
"convención de llamada %s no reconocida, debe ser una de las siguientes:",
null,
"%s",
null,
null,
"el tipo subyacente del tipo de enumeración debe ser un tipo entero",
Expand Down Expand Up @@ -2953,9 +2953,9 @@
"valor de pragma pack %s no válido para la función con restricción amp",
"no se permiten especificadores de restricción superpuestos",
"los especificadores de restricción del destructor deben cubrir la unión de los especificadores de restricción de todos los constructores",
"<error>",
"error",
"nostdlib requiere al menos un uso forzado",
"<error-type>",
"error-type",
null,
null,
null,
Expand Down
Loading
Loading