Rename parameter to forceHeadless

microsoft · Jan 25, 2024 · 807713c · 807713c
1 parent 94eb729
commit 807713c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/src/utils.ts b/src/utils.ts
@@ -390,17 +390,17 @@ export async function getBrowserPath(config: Partial<IUserConfig> = {}): Promise
  * @param port The port on which to enable remote debugging
  * @param targetUrl The url of the page to open
  * @param userDataDir The user data directory for the launched instance
- * @param headleassOverride This overrides the --headless arg for browser launch
+ * @param forceHeadless This force overrides the --headless arg for browser launch
  */
-export async function launchBrowser(browserPath: string, port: number, targetUrl: string, userDataDir?: string, headleassOverride?: boolean): Promise<puppeteer.Browser> {
+export async function launchBrowser(browserPath: string, port: number, targetUrl: string, userDataDir?: string, forceHeadless?: boolean): Promise<puppeteer.Browser> {
  const args = [
  '--no-first-run',
  '--no-default-browser-check',
  `--remote-debugging-port=${port}`,
  targetUrl,
  ];
 
- const headless: boolean = headleassOverride ?? isHeadlessEnabled();
+ const headless: boolean = forceHeadless ?? isHeadlessEnabled();
 
  let browserArgs: string[] = getBrowserArgs();
  browserArgs = browserArgs.filter(arg => !arg.startsWith('--remote-debugging-port') && arg !== targetUrl);

diff --git a/test/extension.test.ts b/test/extension.test.ts
@@ -472,7 +472,6 @@ describe("extension", () => {
  }));
  });
 
-
  it("can launch html files in non-remote contexts", async () => {
  mockVSCode.env.remoteName = undefined;
  const testFileUri = {