Skip to content

Commit

Permalink
Patch for missing icons (#2045)
Browse files Browse the repository at this point in the history
This PR patches an issue where the icons are being displayed as white squares with this patch Edge Devtools version 122+ will default to last working version 121
  • Loading branch information
vidorteg committed Feb 29, 2024
1 parent e44b6ec commit 892368d
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions src/versionSocketConnection.ts
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,13 @@ export class BrowserVersionDetectionSocket extends EventEmitter {
const currentVersion = versionNum.split('.').map(part => Number(part));
const minSupportedVersion = MIN_SUPPORTED_VERSION.split('.').map(part => Number(part));
const currentRevision = data.result.revision || '';

// TODO: Workaround https://github.com/microsoft/vscode-edge-devtools/issues/1992
// remove when it has been fixed
if (parseFloat(versionNum) > 121) {
return {revision: '@d550f77b048ac142a3292397c64cdb693e4aca08', isHeadless};
}

for (let i = 0; i < currentVersion.length; i++) {
// Loop through from Major to minor numbers
if (currentVersion[i] > minSupportedVersion[i]) {
Expand Down

0 comments on commit 892368d

Please sign in to comment.