Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing relaunch scenario on headless #1979

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Fixing relaunch scenario on headless #1979

merged 1 commit into from
Jan 30, 2024

Conversation

vidorteg
Copy link
Contributor

Extension was failing to relaunch on headless. This was due to the host responding with Using unsafe HTTP verb GET to invoke /json/new. Recommended way is to use PUT. This PR fixes the issue and adds a test to avoid regression.

Fix #1978

@vidorteg vidorteg merged commit 69f9bd2 into main Jan 30, 2024
4 checks passed
@vidorteg vidorteg deleted the user/vidorteg/fix-get-targets-on-put2 branch January 30, 2024 18:46
@vidorteg vidorteg mentioned this pull request Feb 29, 2024
Merged
vidorteg added a commit that referenced this pull request Feb 29, 2024
@vidorteg
Update to version 2.1.5 (#2048)
565179e 
[Bug Fix]: Fixing relaunch scenario on headless - PR #1979
[Bug Fix]: Patch for missing icons - PR #2045
[Bug Fix]: Updating fallback version to 120 - PR #2046
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElormCoch ElormCoch ElormCoch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extension fails to relaunch an instance (headless)
2 participants
@vidorteg @ElormCoch