Added support for workingDirectories to the 'lint whole folder' task

[Tiberriver256]

Fixes: #633

[dbaeumer]

Nice work. Wasn't aware the pushd & popd is available in all command shells.

[dbaeumer]

But what I found out now is that && is not available under PowerShell so the task will fail if PowerShell is used as a command processor.

[dbaeumer]

And && usually has the semantic that the second command will not run if the first fails. IMO this will stop the shell execution on the first working directory that has an eslint error since eslint returns a exit code different than 0 in that case.

[dbaeumer]

@Tiberriver256 any thoughts on the above comments.

[Tiberriver256]

But what I found out now is that && is not available under PowerShell so the task will fail if PowerShell is used as a command processor.

Yes :( sadly older versions of PowerShell do not have this capability. Newer versions of PowerShell core do have support for it. We could look into using ; instead but I'm not sure if that's supported in cmd.exe. It should work in Bash & PowerShell and would give us the behavior of running all the commands regardless of whether or not one failed.

And && usually has the semantic that the second command will not run if the first fails. IMO this will stop the shell execution on the first working directory that has an eslint error since eslint returns a exit code different than 0 in that case.

This is correct. Was a royal pain when I was testing it out locally to make sure I had run npm install in all my folders before it would run right.

@Tiberriver256 any thoughts on the above comments.

Overall... feels flakey... I kinda want instead of one mega task, one task per folder. Instead of seeing this:

• eslint whole folder

I would see:

• eslint whole ./project1 folder
• eslint whole ./project2 folder
• eslint whole ./project3 folder

What do you think?

[dbaeumer]

I will talk to the task developer in VS Code to see what we can do here.

[dbaeumer]

Here is an idea you could experiment with:

• have a task per working directory
• contribute a command to execute all tasks. The implementation of the command could use the workbench.action.tasks.runTask API command documented here: https://code.visualstudio.com/api/references/commands

Let me know how it goes

[Tiberriver256]

Here is an idea you could experiment with:

• have a task per working directory
• contribute a command to execute all tasks. The implementation of the command could use the workbench.action.tasks.runTask API command documented here: https://code.visualstudio.com/api/references/commands

Let me know how it goes

Nice! I'll give it a go.