Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create data-connect-dataset-viva #1002

Closed
wants to merge 24 commits into from

Conversation

lorieide
Copy link
Contributor

Add new file for Viva dataset.

Add new file for Viva dataset.
@kestrel144 kestrel144 self-requested a review August 10, 2023 18:40
@kestrel144 kestrel144 added the ready for content review PR is ready for a content review - content development and tech review are complete. label Aug 10, 2023
@microsoft-github-policy-service
Copy link
Contributor

Thank you for indicating that your pull request is ready for content review, @lorieide. It has been added to the Content Review project and an available reviewer will be assigned in the next 15 business days, depending on demand. You can monitor the status of your pull request in the editorial process here.

Check the content review workflow here.

@kestrel144 kestrel144 requested a review from rimisra2 August 10, 2023 20:32
update review comments from Joanna's tech lead
Add introductory sentence for the dataset.
Incorporated Joanna's changes from 8/14.
@lorieide lorieide requested a review from jozhuan August 14, 2023 22:55
@learn-build-service-prod
Copy link

Learn Build status updates of commit 9036823:

✅ Validation status: passed

File Status Preview URL Details
concepts/data-connect-dataset-viva.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@learn-build-service-prod
Copy link

Learn Build status updates of commit e89e4c3:

✅ Validation status: passed

File Status Preview URL Details
concepts/data-connect-dataset-viva.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@learn-build-service-prod
Copy link

Learn Build status updates of commit ecacfb3:

⚠️ Validation status: warnings

File Status Preview URL Details
concepts/beta/api/b2cidentityuserflow-list-userflowidentityproviders.md ⚠️Warning Details
concepts/beta/api/b2xidentityuserflow-list-userflowidentityproviders.md ⚠️Warning Details
concepts/data-connect-dataset-viva.md ✅Succeeded

concepts/beta/api/b2cidentityuserflow-list-userflowidentityproviders.md

  • Line 2, Column 8: [Warning: duplicate-titles - See documentation] Title 'List a userflowidentityproviders - Microsoft Graph beta' is duplicated in: 'beta/api/b2cidentityuserflow-list-userflowidentityproviders.md(2,8), beta/api/b2xidentityuserflow-list-userflowidentityproviders.md(2,8)'. Titles must be unique within a docset.
  • Line 10, Column 1: [Warning: duplicate-h1s - See documentation] H1 'List a userflowidentityproviders' is duplicated with other articles: 'beta/api/b2cidentityuserflow-list-userflowidentityproviders.md(10,1), beta/api/b2xidentityuserflow-list-userflowidentityproviders.md(10,1)'. First level headings must be unique within a docset.

concepts/beta/api/b2xidentityuserflow-list-userflowidentityproviders.md

  • Line 2, Column 8: [Warning: duplicate-titles - See documentation] Title 'List a userflowidentityproviders - Microsoft Graph beta' is duplicated in: 'beta/api/b2cidentityuserflow-list-userflowidentityproviders.md(2,8), beta/api/b2xidentityuserflow-list-userflowidentityproviders.md(2,8)'. Titles must be unique within a docset.
  • Line 10, Column 1: [Warning: duplicate-h1s - See documentation] H1 'List a userflowidentityproviders' is duplicated with other articles: 'beta/api/b2cidentityuserflow-list-userflowidentityproviders.md(10,1), beta/api/b2xidentityuserflow-list-userflowidentityproviders.md(10,1)'. First level headings must be unique within a docset.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Added Power BI template description and link in the Categories section.,
@lorieide lorieide requested a review from jozhuan August 16, 2023 15:45
@learn-build-service-prod
Copy link

Learn Build status updates of commit e2df5c7:

✅ Validation status: passed

File Status Preview URL Details
concepts/data-connect-dataset-viva.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@lorieide
Copy link
Contributor Author

lorieide commented Aug 16, 2023

@jozhuan I've included the Power BI templates info in the Categories section. It's ready and now up to Laura Graham to review and merge to the main branch.

@lorieide lorieide requested a review from jozhuan August 16, 2023 15:48
@learn-build-service-prod
Copy link

Learn Build status updates of commit ea1b794:

✅ Validation status: passed

File Status Preview URL Details
concepts/data-connect-dataset-viva.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@lorieide
Copy link
Contributor Author

#feedback-addressed

@learn-build-service-prod
Copy link

Learn Build status updates of commit b2f1e3c:

✅ Validation status: passed

File Status Preview URL Details
concepts/data-connect-dataset-viva.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@learn-build-service-prod
Copy link

Learn Build status updates of commit 980acdd:

✅ Validation status: passed

File Status Preview URL Details
concepts/data-connect-dataset-viva.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@learn-build-service-prod
Copy link

Learn Build status updates of commit bdad418:

⚠️ Validation status: warnings

File Status Preview URL Details
concepts/data-connect-dataset-viva.md ⚠️Warning Details

concepts/data-connect-dataset-viva.md

  • Line 52, Column 1: [Warning: file-not-found - See documentation] Invalid file link: 'viva/insights/advanced/introduction-to-advanced-insights'.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@lorieide
Copy link
Contributor Author

#feedback-addressed

@lorieide lorieide requested a review from Lauragra August 22, 2023 15:54
@learn-build-service-prod
Copy link

Learn Build status updates of commit 4942e9b:

⚠️ Validation status: warnings

File Status Preview URL Details
concepts/data-connect-dataset-viva.md ⚠️Warning Details

concepts/data-connect-dataset-viva.md

  • Line 52, Column 1: [Warning: file-not-found - See documentation] Invalid file link: 'viva/insights/advanced/introduction-to-advanced-insights'.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@learn-build-service-prod
Copy link

Learn Build status updates of commit ce4352d:

⚠️ Validation status: warnings

File Status Preview URL Details
concepts/data-connect-dataset-viva.md ⚠️Warning Details

concepts/data-connect-dataset-viva.md

  • Line 52, Column 1: [Warning: file-not-found - See documentation] Invalid file link: 'viva/insights/advanced/introduction-to-advanced-insights'.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@lorieide lorieide removed their assignment Aug 25, 2023
@lorieide
Copy link
Contributor Author

lorieide commented Aug 25, 2023

@Lauragra Is this PR ready to merge with main now that all the feedback has been addressed? Thanks

@learn-build-service-prod
Copy link

Learn Build status updates of commit bf4c4a4:

✅ Validation status: passed

File Status Preview URL Details
concepts/data-connect-dataset-viva.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@learn-build-service-prod
Copy link

Learn Build status updates of commit e46a243:

✅ Validation status: passed

File Status Preview URL Details
concepts/data-connect-dataset-viva.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@learn-build-service-prod
Copy link

Learn Build status updates of commit c9779a3:

✅ Validation status: passed

File Status Preview URL Details
concepts/data-connect-dataset-viva.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@lorieide
Copy link
Contributor Author

lorieide commented Aug 27, 2023

@Lauragra I found out this topic is for a private preview release, therefore the PM Joanna requested it not be included in the TOC.

@Lauragra
Copy link
Contributor

Lauragra commented Sep 2, 2023

@Lauragra I found out this topic is for a private preview release, therefore the PM Joanna requested it not be included in the TOC.

@lorieide , yes, we're not going to publish this topic until the public preview. I'm following up to see if we can close this PR and move it into the private authoring repo.

@lorieide
Copy link
Contributor Author

lorieide commented Sep 5, 2023

@Lauragra Yes, please do feel free to close this PR and move to private repo. :) It's my last PR on the project, and it's been super fantastic to work with you once again! - Lori (lorieide@outlook.com)

@learn-build-service-prod
Copy link

Learn Build status updates of commit 65ab5e0:

✅ Validation status: passed

File Status Preview URL Details
concepts/data-connect-dataset-viva.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@Lauragra
Copy link
Contributor

Lauragra commented Sep 5, 2023

@Lauragra Yes, please do feel free to close this PR and move to private repo. :) It's my last PR on the project, and it's been super fantastic to work with you once again! - Lori (lorieide@outlook.com)

Hope to work with you again soon! -Laura

@microsoft-github-policy-service
Copy link
Contributor

Hello, @lorieide.

Your PR has been in "Changes requested" state for more than 2 weeks.

Please address the feedback left by your reviewer. Feel free to ping your reviewer on the side if you have any questions.

Thank you!

@Lauragra Lauragra closed this Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants