-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create data-connect-dataset-viva #1002
Conversation
Add new file for Viva dataset.
Thank you for indicating that your pull request is ready for content review, @lorieide. It has been added to the Content Review project and an available reviewer will be assigned in the next 15 business days, depending on demand. You can monitor the status of your pull request in the editorial process here. Check the content review workflow here. |
add .md to the filename
update review comments from Joanna's tech lead
edit correction
Add introductory sentence for the dataset.
Incorporated Joanna's changes from 8/14.
Learn Build status updates of commit 9036823: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Learn Build status updates of commit e89e4c3: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Learn Build status updates of commit ecacfb3:
|
File | Status | Preview URL | Details |
---|---|---|---|
concepts/beta/api/b2cidentityuserflow-list-userflowidentityproviders.md | Details | ||
concepts/beta/api/b2xidentityuserflow-list-userflowidentityproviders.md | Details | ||
concepts/data-connect-dataset-viva.md | ✅Succeeded |
concepts/beta/api/b2cidentityuserflow-list-userflowidentityproviders.md
- Line 2, Column 8: [Warning: duplicate-titles - See documentation]
Title 'List a userflowidentityproviders - Microsoft Graph beta' is duplicated in: 'beta/api/b2cidentityuserflow-list-userflowidentityproviders.md(2,8), beta/api/b2xidentityuserflow-list-userflowidentityproviders.md(2,8)'. Titles must be unique within a docset.
- Line 10, Column 1: [Warning: duplicate-h1s - See documentation]
H1 'List a userflowidentityproviders' is duplicated with other articles: 'beta/api/b2cidentityuserflow-list-userflowidentityproviders.md(10,1), beta/api/b2xidentityuserflow-list-userflowidentityproviders.md(10,1)'. First level headings must be unique within a docset.
concepts/beta/api/b2xidentityuserflow-list-userflowidentityproviders.md
- Line 2, Column 8: [Warning: duplicate-titles - See documentation]
Title 'List a userflowidentityproviders - Microsoft Graph beta' is duplicated in: 'beta/api/b2cidentityuserflow-list-userflowidentityproviders.md(2,8), beta/api/b2xidentityuserflow-list-userflowidentityproviders.md(2,8)'. Titles must be unique within a docset.
- Line 10, Column 1: [Warning: duplicate-h1s - See documentation]
H1 'List a userflowidentityproviders' is duplicated with other articles: 'beta/api/b2cidentityuserflow-list-userflowidentityproviders.md(10,1), beta/api/b2xidentityuserflow-list-userflowidentityproviders.md(10,1)'. First level headings must be unique within a docset.
For more details, please refer to the build report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
- Try searching the learn.microsoft.com contributor guides
- Post your question in the Learn support channel
Added Power BI template description and link in the Categories section.,
Learn Build status updates of commit e2df5c7: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
@jozhuan I've included the Power BI templates info in the Categories section. It's ready and now up to Laura Graham to review and merge to the main branch. |
Learn Build status updates of commit ea1b794: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
#feedback-addressed |
Learn Build status updates of commit b2f1e3c: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Learn Build status updates of commit 980acdd: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Incorporate Laura's round 2 feedback.
Learn Build status updates of commit bdad418:
|
File | Status | Preview URL | Details |
---|---|---|---|
concepts/data-connect-dataset-viva.md | Details |
concepts/data-connect-dataset-viva.md
- Line 52, Column 1: [Warning: file-not-found - See documentation]
Invalid file link: 'viva/insights/advanced/introduction-to-advanced-insights'.
For more details, please refer to the build report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
- Try searching the learn.microsoft.com contributor guides
- Post your question in the Learn support channel
small fix
#feedback-addressed |
Learn Build status updates of commit 4942e9b:
|
File | Status | Preview URL | Details |
---|---|---|---|
concepts/data-connect-dataset-viva.md | Details |
concepts/data-connect-dataset-viva.md
- Line 52, Column 1: [Warning: file-not-found - See documentation]
Invalid file link: 'viva/insights/advanced/introduction-to-advanced-insights'.
For more details, please refer to the build report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
- Try searching the learn.microsoft.com contributor guides
- Post your question in the Learn support channel
Learn Build status updates of commit ce4352d:
|
File | Status | Preview URL | Details |
---|---|---|---|
concepts/data-connect-dataset-viva.md | Details |
concepts/data-connect-dataset-viva.md
- Line 52, Column 1: [Warning: file-not-found - See documentation]
Invalid file link: 'viva/insights/advanced/introduction-to-advanced-insights'.
For more details, please refer to the build report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
- Try searching the learn.microsoft.com contributor guides
- Post your question in the Learn support channel
remove broken link
@Lauragra Is this PR ready to merge with main now that all the feedback has been addressed? Thanks |
Learn Build status updates of commit bf4c4a4: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Learn Build status updates of commit e46a243: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Learn Build status updates of commit c9779a3: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
@Lauragra I found out this topic is for a private preview release, therefore the PM Joanna requested it not be included in the TOC. |
@lorieide , yes, we're not going to publish this topic until the public preview. I'm following up to see if we can close this PR and move it into the private authoring repo. |
@Lauragra Yes, please do feel free to close this PR and move to private repo. :) It's my last PR on the project, and it's been super fantastic to work with you once again! - Lori (lorieide@outlook.com) |
Learn Build status updates of commit 65ab5e0: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Hope to work with you again soon! -Laura |
Hello, @lorieide. Your PR has been in "Changes requested" state for more than 2 weeks. Please address the feedback left by your reviewer. Feel free to ping your reviewer on the side if you have any questions. Thank you! |
Add new file for Viva dataset.