Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes incomplete uploads due to properties mismatch #719

Merged
merged 2 commits into from
Sep 1, 2023

Conversation

andrueastman
Copy link
Member

@andrueastman andrueastman commented Sep 1, 2023

Fixes microsoftgraph/msgraph-sdk-dotnet#2092

The uploadSession payload sometimes returns with a property values that are pascal cased. This PR adds a couple of function to the UploadSession deserializers to enable uploads to not stop due to missing information.

cc @GeoffreyYue1

Microsoft Reviewers: Open in CodeFlow

@andrueastman andrueastman marked this pull request as ready for review September 1, 2023 12:23
@andrueastman andrueastman requested a review from a team as a code owner September 1, 2023 12:23
src/Microsoft.Graph.Core/Models/UploadSession.cs Outdated Show resolved Hide resolved
src/Microsoft.Graph.Core/Models/UploadSession.cs Outdated Show resolved Hide resolved
src/Microsoft.Graph.Core/Models/UploadSession.cs Outdated Show resolved Hide resolved
src/Microsoft.Graph.Core/Models/UploadSession.cs Outdated Show resolved Hide resolved
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes!

@andrueastman andrueastman merged commit d08fa46 into dev Sep 1, 2023
5 checks passed
@andrueastman andrueastman deleted the andrueastman/fixProperties branch September 1, 2023 13:14
@andrueastman andrueastman mentioned this pull request Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Email large attachments cannot be fully uploaded after upgrading to .net Graph SDK 5.x.
2 participants