Generated models and request builders #2088
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrueastman
commented
Aug 22, 2023
| @@ -1,71 +0,0 @@ | |||
| // <auto-generated/> | |||
There was a problem hiding this comment.
TODO: verify if this removal is intended.
MartinM85
reviewed
Aug 23, 2023
| @@ -62,8 +62,8 @@ public class ConversationsRequestBuilder : BaseRequestBuilder { | |||
| return await RequestAdapter.SendAsync<ConversationCollectionResponse>(requestInfo, ConversationCollectionResponse.CreateFromDiscriminatorValue, errorMapping, cancellationToken); | |||
| } | |||
| /// <summary> | |||
| /// Use reply thread or reply post to further post to that conversation. | |||
| /// Find more info here <see href="https://learn.microsoft.com/graph/api/group-post-conversations?view=graph-rest-1.0" /> | |||
| /// Create an open extension (openTypeExtension object) and add custom properties in a new or existing instance of a resource. You can create an open extension in a resource instance and store custom data to it all in the same operation, except for specific resources. The table in the Permissions section lists the resources that support open extensions. | |||
There was a problem hiding this comment.
The description is confusing for the method that creates a new conversation. The same description is already there for ExtensionsRequestBuilders.
|
Closing this for now as its now superceded via #2091 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request was automatically created by Azure Pipelines. Important Check for unexpected deletions or changes in this PR.
Microsoft Reviewers: Open in CodeFlow