Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update code samples #1388

Merged
merged 3 commits into from
Nov 2, 2023
Merged

Update code samples #1388

merged 3 commits into from
Nov 2, 2023

Conversation

Ndiritu
Copy link
Contributor

@Ndiritu Ndiritu commented Nov 2, 2023

closes #1370

Microsoft Reviewers: Open in CodeFlow

@Ndiritu Ndiritu requested a review from isvargasmsft November 2, 2023 03:18
@Ndiritu Ndiritu self-assigned this Nov 2, 2023
@Ndiritu Ndiritu requested a review from a team as a code owner November 2, 2023 03:18
Comment on lines +331 to +343
$retries = 0;
$maxRetries = 3;
while ($retries < $maxRetries) {
try {
$uploadSession = $largeFileUpload->resume()->wait();
if ($uploadSession) {
break;
}
} catch (NetworkExceptionInterface $ex) {
$retries ++;
}
}
throw $ex;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@waldekmastykarz thoughts?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@Ndiritu Ndiritu merged commit 47dd5dd into feat/kiota-preview Nov 2, 2023
6 checks passed
@Ndiritu Ndiritu deleted the fix/code-samples branch November 2, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants