Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My project #22

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

Olamiflow6577
Copy link

Made the necessary changes required

Copy link

@mahbubul14 mahbubul14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Olamiflow6577,

Good job so far! 👍
There are some issues that you still need to work on to go to the next project but you are almost there!

Required Changes ♻️

  • Kindly use the correct GitHub flow. Branch should have a name of a feature or action (e.g. 'created_sidebar' or 'added_comments_section'). Pull Request is made from the feature branch into the main branch. You can now check out to a new branch and use the correct name and mention the old PR in the new PR.

  • Currently, your README file is not updated according to the project. Please update your README file. You have used the template but forgot to customize it to your project. 👍

  • You have no linter set up for this project. kindly work on it. 👍

  • There should be a .gitignore file listing test.md file and node_modules directory (as it can be added by accident while setting up Linters).

To Highlights

✔️ Commit messages are meaningful.

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better.

  • N/A

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification. You can also reach me on slack

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Copy link

@Shedrack-Sunday Shedrack-Sunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Olamiflow6577

Good job so far! 👍
There are some issues that you still need to work on to go to the next project but you are almost there!

Required Changes ♻️

  • Kindly use the correct GitHub flow. The branch should have the name of a feature or action (e.g. 'created_sidebar' or 'added_comments_section'). Pull Request is made from the feature branch into the main branch. You can now check out to a new branch and use the correct name and mention the old PR in the new PR.

  • Currently, your README file is not updated according to the project. Please update your README file. You have used the template but forgot to customize it to your project. Only the FAQ is optional👍

  • You have no linter set up for this project. kindly work on it. 👍

There should be a .gitignore file listing test.md file and node_modules directory (as it can be added by accident while setting up Linters).

To Highlights
✔️ Commit messages are meaningful.

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better.

N/A
Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification. You can also reach me on slack

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Copy link

@abdulhamiid abdulhamiid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Status: Required Changes ♻️

Hi @Olamiflow6577 👋,

Great work on making the changes requested by a previous reviewer 👏
You've done well implementing some of the requested changes, I really appreciate the effort you put in! but there are still some which haven't been addressed yet.

Alt Text

Highlights 🌟

  • ✔️ Meaningful commit messages.

Required Changes ♻️

Please kindly check the comments under the review.

[REQUIRED] As requested by the previous reviewers and according to the project requirements, we are supposed to use the correct (GitHub flow) for this project.

I noticed that you have opened a Pull Request from your Repo main branch to Microverse's. Kindly change your base branch back to your branch instead of Microverse's. 🙏
Here is a guideline on how to change your base branch to your branch

Your pull request should be opened from feature-branch to main and not from Olamiflow6577:master to microverseinc:master 🤗🤝

Kindly Check here to learn more about GitHub flow rules. 💪

[REQUIRED] - As requested by the previous reviewers, kindly set up the html-css linters for your repository. The use of linters helps to diagnose and fix technical issues—e.g. code smells—in the code. As a result, fewer defects make their way to production.

[REQURED] - As requested by the previous reviewer, please kindly customize your readme file. we add a README file to a repository to communicate important information about our project. It comprises information that is frequently needed to grasp the scope of the project.

Optional suggestions 🤷‍♂️

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better.

Cheers and Happy coding!👏👏👏

Important Notes 📝

  • Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
  • Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants