Review hellow microverse project #8
Conversation
|  | ||
|
|
There was a problem hiding this comment.
- I suggest you make your comments clearer so that students can understand what is expected of them
| ### Setup | ||
| -None | ||
|
|
||
|
|
||
| ### Install | ||
| -Git | ||
|
|
||
| ### Usage | ||
| -None | ||
|
|
||
| ### Run tests | ||
| -None | ||
|
|
||
| ### Deployment | ||
| -None |
There was a problem hiding this comment.
- Kindly make your comments clear and easy to understand. For Example:
This is a clear comment: The README's "Built With" and "Getting Started" sections are currently empty. Why don't you add content, listing the technology used in the project and how to run it, to them so your README is more informative and professional?
This is a vague comment: The README is not descriptive, why don't you make it better?
There was a problem hiding this comment.
There are two README files. One in main branch and one in htmlcss-branch. Which one should I change?
mohamedelshamy55
changed the title
There was a problem hiding this comment.
Hi 👋,
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!
Required Changes ♻️
- Remember to explain why you request a change - it might be obvious for you but not for someone else.
- Check below and make the necessary changes
Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
You can also consider:
- You can include emojis and gifs to make your code review more human-friendly 👽.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
| ### Setup | ||
| -None | ||
|
|
||
|
|
||
| ### Install | ||
| -Git | ||
|
|
||
| ### Usage | ||
| -None | ||
|
|
||
| ### Run tests | ||
| -None | ||
|
|
||
| ### Deployment | ||
| -None |
There was a problem hiding this comment.
- Kindly make your comments clear and easy to understand. For Example:
This is a clear comment: The README's "Built With" and "Getting Started" sections are currently empty. Why don't you add content, listing the technology used in the project and how to run it, to them so your README is more informative and professional?
This is a vague comment: The README is not descriptive, why don't you make it better?
|  | ||
|
|
There was a problem hiding this comment.
- I suggest you make your comments clearer so that students can understand what is expected of them
| <style> | ||
| h1 { | ||
| font-size: 18pt; | ||
| font-family: tahoma; | ||
| color: #CC3300; | ||
| } | ||
|
|
There was a problem hiding this comment.
Please remove style from the HTML page and put it in the CSS page.
This is good for showing page readability.
There was a problem hiding this comment.
Project Approved 🚀
Hi @mohamedelshamy55 🥇,
Your project is complete! There is nothing else to say other than... it's time to merge it 
Congratulations! 🎉
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
|
Hello @mohamedelshamy55, |
Review requirements