Fixed theme switching bug related to page transitions. #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for animated-churros-60739d ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
alanescarcha
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue ref: #46
transition:persistpara indicar a Astro que mantenga el estado entre transiciones a los botones/dropdown de la funcionalidad de cambio de tema.astro:after-swapque ayudará a refrescar el tema luego de una Transición entre páginas/ruta, debido a que en ciertas ocasiones no solo los botones se rompen, si no que el tema no se actualiza.Motivo del bug:
El problema ocurre debido a las
<ViewTransitions/>de Astro, justo al momento de redireccionar a otra página/ruta mediante un anchor tag.Finalmente:
Ofrezco esta solución ya qué experimenté el mismo problema en mi porfolio incluso sin tener un Dropdown y solo ser un botón de ThemeToggle.
Espero sea de ayuda!