Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement std::is_integral #52

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

ademuri
Copy link

@ademuri ademuri commented Feb 8, 2020

I tested that this compiles for Arduino UNO, including vectors with
integral and non-integral types.

I tested that this compiles for Arduino UNO, including vectors with
integral and non-integral types.
ademuri added a commit to ademuri/smart-input-filter that referenced this pull request Feb 8, 2020
This requires a pull request be merged to ArduinoSTL before it will
build on AVR-based platforms (e.g. UNO).
mike-matera/ArduinoSTL#52
ademuri added a commit to ademuri/smart-input-filter that referenced this pull request Feb 8, 2020
This requires a pull request be merged to ArduinoSTL before it will
build on AVR-based platforms (e.g. UNO).
mike-matera/ArduinoSTL#52
@mike-matera
Copy link
Owner

Hello! Thank you!

I'm concerned that this takes away the is_integer templates from C++11 without compiler checks. Should we make sure that if you're using C++11 that the old code is still there?

@matthijskooijman
Copy link

@mike-matera What's your take on adding new (C++11) features to this library? In previous incarnations of this library, I think there was a tendency to stick to uclibc++ as much as possible and only make Arduino-specific changes. One downside of adding new C++11 features is that the available features become more fragmented, with some of them supported but not all of them, making it also harder for another library to add C++11 features (i.e. risk of duplication).

One example of such a library is https://github.com/hideakitai/ArxTypeTraits, which was originally intended to add just the C++11 <type_traits> library, but has since been extended to provide a lot of C++11 (and beyond) features on top of a C++98 libstdc++. A few years ago, I contributed some changes to that library so it would work together with ArduinoSTL, so maybe you could consider referring to that library for missing C++11 features instead of adding them here? The function implemented by this particular PR (std::is_integral) is already provided by that library, for example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants