Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirmless Button #7

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

maddox
Copy link

@maddox maddox commented Mar 2, 2012

I know this pull request is completely COUNTER to the point of the project, but the MAConfirmButton just looks so nice I wanted to use it as a regular button too.

The following pull request adds the ability to have a confirmless button. Just pass nil into confirm: when creating the button, and the button will act like a normal button, but beautiful.

* check to see if the confirm message is nil, if so, go ahead and just
execute the button
* don't add the overlay if there is no confirm message
@mikeahmarani
Copy link
Owner

Haha glad you like the control! It's actually due for a rewrite I think... but I haven't needed it for awhile so I haven't bothered. I'll take a look at the commits\example later and merge it if nothing is broke. Don't see why not :P

@maddox
Copy link
Author

maddox commented Mar 2, 2012

I'd love to see the button get resized up and down with the font size. It turns out they're just a hair too big for the UI i'm implementing, but I'm using them anyways.

@mikeahmarani
Copy link
Owner

Yeah, like I said it needs a rewrite but it suited my needs at the time. Next time I use it in a project I'll probably take care of that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants