fix deploy slack

mikeheft · Jul 7, 2024 · 4e85230 · 4e85230
1 parent 5fc0297
commit 4e85230
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/.github/workflows/terraform_and_deploy.yaml b/.github/workflows/terraform_and_deploy.yaml
@@ -73,7 +73,7 @@ jobs:
 
     if: |
       always() &&
-      needs.terraform.result == 'success' || needs.terraform.result == 'skipped' &&
+      (needs.terraform.result == 'success' || needs.terraform.result == 'skipped') &&
       needs.rubocop.result == 'success' &&
       needs.rspec.result == 'success'
     steps:
@@ -140,8 +140,8 @@ jobs:
         env:
           SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK }}
           SLACK_MESSAGE: |
-            Your deployment of [${{ github.event.pull_request.title }}](${{ github.event.pull_request.html_url }})
-            has failed'
+            Your deployment of  ${{ github.even.pull_request.title }} <https://${{ github.event.pull_request.html_url }}|#${{ github.event.number }}
+            has failed
         with:
           status: ${{ job.status }}
           emoji: ":error:"