1 implement rubocop #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
mikeheft
commented
Jul 2, 2024
| config.generators.after_generate do |files| | ||
| parsable_files = files.filter { |file| file.end_with?('.rb') } | ||
| unless parsable_files.empty? | ||
| system("bundle exec rubocop -A --fail-level=E #{parsable_files.shelljoin}", exception: true) |
There was a problem hiding this comment.
From the rubocop documentation, this will autocorrect issues when using rails g
mikeheft
commented
Jul 2, 2024
| # This cop enforces that private methods are defined using | ||
| # `private def` for instance methods or | ||
| # `private_class_method def self` for class methods. | ||
| class PrivateMethodStyle < Base |
There was a problem hiding this comment.
This is just a personal preference. I like having each method inlined with the modifier. IMO this makes is more clear and future developers won't need to find the visibility modifier to make sure that new private methods are within that scope.
mikeheft
commented
Jul 2, 2024
| # frozen_string_literal: true | ||
|
|
||
| # Load all Ruby files in the custom directory | ||
| Dir[File.join(__dir__, "**/*.rb")].each { |file| require file } |
There was a problem hiding this comment.
Ensures that the custom cops are required in the .rubocop.yml file. This is a forward fix that will make sure that any new cops are automatically included.
__dir__Returns the canonicalized absolute path of the directory of the file from which this method is called
Documentation link
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1