proof-general narya-solve-hole function #26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used the changes in
hole-offsets
branch, edited thenarya-handle-output
and wrotenarya-solve-hole
function. I did not observe any error we received before, so I think it's better now.What I've done :
add
narya-pending-hole-positions
in order to store temporarily the hole positions when executing commands invisibly.edited
narya-handle-output
so that if called with an invisible command, store hole data in pending position instead of creating overlays immediately.created
narya-solve-hole
with the following properties:?
", then you will be asked to enter aterm
solve %d := term
command, then the hole will be replaced with(term)
. Putting parentheses is to avoid possible parsing problem. If we find a better way, we can edit this in the future.term
includes new holes, we should store them innarya-hole
again.narya-pending-hole-positions
is cleared, ensuring no redundant data remains.Let me know if you think it needs correction or more improvement.