Generate Automatic-Module-Name attribute
#1375
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As it stands, Java 9 Platform Module System cannot infer module name from shapeless' jars due to cross compilation (underscores in `_2.xx`). This simple change adds an `Automatic-Module-Name` attribute to MANIFEST, making it possible to require `shapeless` modules, rather than going through various repackaaging hacks. A proper modularization would include definition of `module-info.java` but that's outside the scope.
|
Any problem with this PR? This should unblock anyone who wants to use |
joroKr21
reviewed
Oct 14, 2024
| .settings(moduleName := "shapeless") | ||
| .settings( | ||
| moduleName := "shapeless", | ||
| javaModuleName := "shapeless.core" |
There was a problem hiding this comment.
Perhaps we should use just shapeless for this one? Shapeless 2 is not really modular, the plugin and scratch are not published artifacts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it stands, Java 9 Platform Module System cannot infer module name from shapeless' jars due to cross compilation (underscores in
_2.xx).This simple change adds an
Automatic-Module-Nameattribute to MANIFEST, making it possible to requireshapelessmodules, rather than going through various repackaaging hacks.A proper modularization would include definition of
module-info.javabut that's outside the scope.