Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Notebook and Apps for DZone Article #1412

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tspannhw
Copy link

@tspannhw tspannhw commented Sep 5, 2024

  • A reference to a related issue in your repository.

Added notebook and apps for

https://dzone.com/articles/multiple-vectors-and-advanced-search-data-model-design

  • A description of the changes proposed in the pull request.

New directory for my notebook and 2 python scripts

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tspannhw

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot
Copy link

Welcome @tspannhw! It looks like this is your first PR to milvus-io/bootcamp 🎉

Copy link

review-notebook-app bot commented Sep 6, 2024

View / edit / reply to this conversation on ReviewNB

codingjaguar commented on 2024-09-06T00:24:17Z
----------------------------------------------------------------

Nit, weird double blank separation, e.g.

options. For


Copy link

review-notebook-app bot commented Sep 6, 2024

View / edit / reply to this conversation on ReviewNB

codingjaguar commented on 2024-09-06T00:24:17Z
----------------------------------------------------------------

maybe group these sections into a section called dataset? Or better, a structure like this:

🔍 Summary

📊 Dataset Used in This Notebook

📊 Start Building

Install Dependencies

...

Conclusion


Copy link

review-notebook-app bot commented Sep 6, 2024

View / edit / reply to this conversation on ReviewNB

codingjaguar commented on 2024-09-06T00:24:18Z
----------------------------------------------------------------

Where is the section of ingesting data? Only saw code for preparing the search query.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants