[1.x] Laravel way polymorphic relationship #18
Conversation
milwad-dev
changed the title
|
Did breaking changes? |
Maybe 😊. I accidentally came across the package and did a PR in 2 minutes and didn't test it. I will find time and try to fix it. I found that you don't use indexes in the database, which can slow down working with large amounts of data, and you also don't use migration helpers for polymorphic relationships, which slightly breaks the "correct way" that the documentation advises. It also seems to me that the uuid setting is not particularly necessary since you give the opportunity to publish the migration. |
|
Good, so please fix the styleci |
I corrected the style |
|
and I just realized that I didn’t create a migration, but corrected an existing one, it turns out that it will be incompatible with previous versions |
|
so I'll post this soon too, so don't combine it yet |
|
seems like everything, but I still haven't tested in the application - I created a new migration in which the columns will be renamed and I also added indexes |
| { | ||
| Schema::table(config('laravel-attributes.tables.name', 'attributes'), function (Blueprint $table) { | ||
| $table->renameColumn('attributable', 'attributable_type'); | ||
| $this->index(['attributable_type', 'attributable_id']); |
| { | ||
| Schema::table(config('laravel-attributes.tables.name', 'attributes'), function (Blueprint $table) { | ||
| $table->renameColumn('attributable_type', 'attributable'); | ||
| $this->index(['attributable_type', 'attributable_id']); |
|
I apologize for the stupid typo, not a very good decision to do PR on the road |
No description provided.