Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connectors: Implement Bebop swap connector #150

Merged
merged 3 commits into from
May 22, 2024

Conversation

lgalende
Copy link
Contributor

This PR implements the logic to execute a token swap using Bebop.
Note some parameters in other Arbitrum tests were modified because the block number was changed. Specifically:

  1. In BalancerV2SwapConnector.behavior - USDC-WETH context, amountIn was decreased because Balancer contract reverted with error reason SWAP_LIMIT.
  2. In BalancerV2SwapConnector.behavior - WBTC-USDC context, amountIn was decreased because Balancer contract reverted with error reason MAX_IN_RATIO.
  3. In HopSwapConnector.arbitrum, SLIPPAGE was increased from 1% to 1.5%.

@lgalende lgalende requested a review from facuspagnuolo May 17, 2024 19:03
@lgalende lgalende self-assigned this May 17, 2024
Copy link
Member

@facuspagnuolo facuspagnuolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.github/scripts/setup-hardhat-config.sh Outdated Show resolved Hide resolved
packages/connectors/src/bebop.ts Outdated Show resolved Hide resolved
@facuspagnuolo facuspagnuolo merged commit 018af86 into master May 22, 2024
4 checks passed
@facuspagnuolo facuspagnuolo deleted the connectors/implement_bebop_swap_connector branch May 22, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants