Skip to content

Add PullRequestCommenter provider trait #8068

Add PullRequestCommenter provider trait

Add PullRequestCommenter provider trait #8068

Triggered via pull request December 12, 2024 13:18
Status Failure
Total duration 4m 56s
Artifacts 1

pr.yml

on: pull_request
license-check  /  License boilerplate check
11s
license-check / License boilerplate check
lint  /  Run golangci-lint
2m 50s
lint / Run golangci-lint
lint  /  Uncommitted changes check - go mod tidy & make gen
3m 32s
lint / Uncommitted changes check - go mod tidy & make gen
build  /  Verify build
1m 20s
build / Verify build
test  /  Unit testing
4m 14s
test / Unit testing
test  /  Authz tests
2m 58s
test / Authz tests
image-build  /  Image build
3m 7s
image-build / Image build
image-build  /  Build Helm chart
3m 4s
image-build / Build Helm chart
image-build  /  Check docker image build
2m 13s
image-build / Check docker image build
security  /  Security Scan
25s
security / Security Scan
compose-migrate  /  docker
1m 46s
compose-migrate / docker
Fit to window
Zoom out
Zoom in

Annotations

49 errors and 10 warnings
security / Security Scan
Process completed with exit code 1.
build / Verify build: internal/engine/actions/alert/alert.go#L63
cannot use client (variable of type "github.com/mindersec/minder/pkg/providers/v1".GitHub) as "github.com/mindersec/minder/pkg/providers/v1".PullRequestCommenter value in argument to pull_request_comment.NewPullRequestCommentAlert: "github.com/mindersec/minder/pkg/providers/v1".GitHub does not implement "github.com/mindersec/minder/pkg/providers/v1".PullRequestCommenter (missing method CommentOnPullRequest)
build / Verify build
Process completed with exit code 2.
compose-migrate / docker: internal/engine/actions/alert/alert.go#L63
cannot use client (variable of type "github.com/mindersec/minder/pkg/providers/v1".GitHub) as "github.com/mindersec/minder/pkg/providers/v1".PullRequestCommenter value in argument to pull_request_comment.NewPullRequestCommentAlert: "github.com/mindersec/minder/pkg/providers/v1".GitHub does not implement "github.com/mindersec/minder/pkg/providers/v1".PullRequestCommenter (missing method CommentOnPullRequest)
compose-migrate / docker: internal/engine/eval/homoglyphs/communication/reviewer.go#L96
ra.ghClient.ListReviews undefined (type "github.com/mindersec/minder/pkg/providers/v1".GitHub has no field or method ListReviews)
compose-migrate / docker: internal/engine/eval/homoglyphs/communication/reviewer.go#L125
ra.ghClient.CreateReview undefined (type "github.com/mindersec/minder/pkg/providers/v1".GitHub has no field or method CreateReview)
compose-migrate / docker: internal/engine/eval/homoglyphs/communication/reviewer.go#L148
ra.ghClient.DismissReview undefined (type "github.com/mindersec/minder/pkg/providers/v1".GitHub has no field or method DismissReview)
compose-migrate / docker: internal/engine/eval/trusty/actions.go#L244
sph.cli.CreateReview undefined (type "github.com/mindersec/minder/pkg/providers/v1".GitHub has no field or method CreateReview)
compose-migrate / docker: internal/engine/eval/vulncheck/review.go#L379
ra.cli.CreateReview undefined (type "github.com/mindersec/minder/pkg/providers/v1".GitHub has no field or method CreateReview)
compose-migrate / docker: internal/engine/eval/vulncheck/review.go#L408
ra.cli.DismissReview undefined (type "github.com/mindersec/minder/pkg/providers/v1".GitHub has no field or method DismissReview)
compose-migrate / docker
Process completed with exit code 2.
image-build / Check docker image build
buildx failed with: ERROR: failed to solve: process "/bin/sh -c CGO_ENABLED=0 go build -trimpath -o minder-server ./cmd/server" did not complete successfully: exit code: 1
lint / Run golangci-lint: internal/engine/actions/actions.go#L19
could not import github.com/mindersec/minder/internal/engine/actions/alert (-: # github.com/mindersec/minder/internal/engine/actions/alert
lint / Run golangci-lint: internal/engine/actions/alert/alert.go#L63
cannot use client (variable of type "github.com/mindersec/minder/pkg/providers/v1".GitHub) as "github.com/mindersec/minder/pkg/providers/v1".PullRequestCommenter value in argument to pull_request_comment.NewPullRequestCommentAlert: "github.com/mindersec/minder/pkg/providers/v1".GitHub does not implement "github.com/mindersec/minder/pkg/providers/v1".PullRequestCommenter (missing method CommentOnPullRequest)) (typecheck)
lint / Run golangci-lint: internal/engine/actions/alert/alert.go#L63
cannot use client (variable of type "github.com/mindersec/minder/pkg/providers/v1".GitHub) as "github.com/mindersec/minder/pkg/providers/v1".PullRequestCommenter value in argument to pull_request_comment.NewPullRequestCommentAlert: "github.com/mindersec/minder/pkg/providers/v1".GitHub does not implement "github.com/mindersec/minder/pkg/providers/v1".PullRequestCommenter (missing method CommentOnPullRequest) (typecheck)
lint / Run golangci-lint: internal/engine/actions/alert/pull_request_comment/pull_request_comment_test.go#L50
mockGitHub.EXPECT().CreateReview undefined (type *mock_github.MockGitHubMockRecorder has no field or method CreateReview)
lint / Run golangci-lint: internal/engine/actions/alert/pull_request_comment/pull_request_comment_test.go#L61
mockGitHub.EXPECT().CreateReview undefined (type *mock_github.MockGitHubMockRecorder has no field or method CreateReview)
lint / Run golangci-lint: internal/engine/actions/alert/pull_request_comment/pull_request_comment_test.go#L73
mockGitHub.EXPECT().DismissReview undefined (type *mock_github.MockGitHubMockRecorder has no field or method DismissReview)
lint / Run golangci-lint: internal/engine/actions/alert/pull_request_comment/pull_request_comment_test.go#L99
cannot use mockClient (variable of type *mock_github.MockGitHub) as "github.com/mindersec/minder/pkg/providers/v1".PullRequestCommenter value in argument to NewPullRequestCommentAlert: *mock_github.MockGitHub does not implement "github.com/mindersec/minder/pkg/providers/v1".PullRequestCommenter (missing method CommentOnPullRequest) (typecheck)
lint / Run golangci-lint: internal/engine/eval/eval.go#L16
could not import github.com/mindersec/minder/internal/engine/eval/trusty (-: # github.com/mindersec/minder/internal/engine/eval/trusty
lint / Run golangci-lint: internal/engine/eval/trusty/actions.go#L244
sph.cli.CreateReview undefined (type "github.com/mindersec/minder/pkg/providers/v1".GitHub has no field or method CreateReview)) (typecheck)
lint / Run golangci-lint: internal/engine/eval/eval.go#L17
could not import github.com/mindersec/minder/internal/engine/eval/vulncheck (-: # github.com/mindersec/minder/internal/engine/eval/vulncheck
image-build / Build Helm chart
cannot use client (variable of type "github.com/mindersec/minder/pkg/providers/v1".GitHub) as "github.com/mindersec/minder/pkg/providers/v1".PullRequestCommenter value in argument to pull_request_comment.NewPullRequestCommentAlert: "github.com/mindersec/minder/pkg/providers/v1".GitHub does not implement "github.com/mindersec/minder/pkg/providers/v1".PullRequestCommenter (missing method CommentOnPullRequest)
image-build / Build Helm chart
ra.ghClient.ListReviews undefined (type "github.com/mindersec/minder/pkg/providers/v1".GitHub has no field or method ListReviews)
image-build / Build Helm chart
ra.ghClient.CreateReview undefined (type "github.com/mindersec/minder/pkg/providers/v1".GitHub has no field or method CreateReview)
image-build / Build Helm chart
ra.ghClient.DismissReview undefined (type "github.com/mindersec/minder/pkg/providers/v1".GitHub has no field or method DismissReview)
image-build / Build Helm chart
sph.cli.CreateReview undefined (type "github.com/mindersec/minder/pkg/providers/v1".GitHub has no field or method CreateReview)
image-build / Build Helm chart
ra.cli.CreateReview undefined (type "github.com/mindersec/minder/pkg/providers/v1".GitHub has no field or method CreateReview)
image-build / Build Helm chart
ra.cli.DismissReview undefined (type "github.com/mindersec/minder/pkg/providers/v1".GitHub has no field or method DismissReview)
image-build / Build Helm chart
Process completed with exit code 2.
image-build / Image build: internal/engine/actions/alert/alert.go#L63
cannot use client (variable of type "github.com/mindersec/minder/pkg/providers/v1".GitHub) as "github.com/mindersec/minder/pkg/providers/v1".PullRequestCommenter value in argument to pull_request_comment.NewPullRequestCommentAlert: "github.com/mindersec/minder/pkg/providers/v1".GitHub does not implement "github.com/mindersec/minder/pkg/providers/v1".PullRequestCommenter (missing method CommentOnPullRequest)
image-build / Image build: internal/engine/eval/homoglyphs/communication/reviewer.go#L96
ra.ghClient.ListReviews undefined (type "github.com/mindersec/minder/pkg/providers/v1".GitHub has no field or method ListReviews)
image-build / Image build: internal/engine/eval/homoglyphs/communication/reviewer.go#L125
ra.ghClient.CreateReview undefined (type "github.com/mindersec/minder/pkg/providers/v1".GitHub has no field or method CreateReview)
image-build / Image build: internal/engine/eval/homoglyphs/communication/reviewer.go#L148
ra.ghClient.DismissReview undefined (type "github.com/mindersec/minder/pkg/providers/v1".GitHub has no field or method DismissReview)
image-build / Image build: internal/engine/eval/trusty/actions.go#L244
sph.cli.CreateReview undefined (type "github.com/mindersec/minder/pkg/providers/v1".GitHub has no field or method CreateReview)
image-build / Image build: internal/engine/eval/vulncheck/review.go#L379
ra.cli.CreateReview undefined (type "github.com/mindersec/minder/pkg/providers/v1".GitHub has no field or method CreateReview)
image-build / Image build: internal/engine/eval/vulncheck/review.go#L408
ra.cli.DismissReview undefined (type "github.com/mindersec/minder/pkg/providers/v1".GitHub has no field or method DismissReview)
image-build / Image build
Process completed with exit code 1.
lint / Uncommitted changes check - go mod tidy & make gen
Process completed with exit code 1.
test / Unit testing: internal/engine/actions/alert/alert.go#L63
cannot use client (variable of type "github.com/mindersec/minder/pkg/providers/v1".GitHub) as "github.com/mindersec/minder/pkg/providers/v1".PullRequestCommenter value in argument to pull_request_comment.NewPullRequestCommentAlert: "github.com/mindersec/minder/pkg/providers/v1".GitHub does not implement "github.com/mindersec/minder/pkg/providers/v1".PullRequestCommenter (missing method CommentOnPullRequest)
test / Unit testing: internal/engine/eval/homoglyphs/communication/reviewer.go#L96
ra.ghClient.ListReviews undefined (type "github.com/mindersec/minder/pkg/providers/v1".GitHub has no field or method ListReviews)
test / Unit testing: internal/engine/eval/homoglyphs/communication/reviewer.go#L125
ra.ghClient.CreateReview undefined (type "github.com/mindersec/minder/pkg/providers/v1".GitHub has no field or method CreateReview)
test / Unit testing: internal/engine/eval/homoglyphs/communication/reviewer.go#L148
ra.ghClient.DismissReview undefined (type "github.com/mindersec/minder/pkg/providers/v1".GitHub has no field or method DismissReview)
test / Unit testing: internal/engine/eval/trusty/actions.go#L244
sph.cli.CreateReview undefined (type "github.com/mindersec/minder/pkg/providers/v1".GitHub has no field or method CreateReview)
test / Unit testing: internal/engine/eval/vulncheck/review.go#L379
ra.cli.CreateReview undefined (type "github.com/mindersec/minder/pkg/providers/v1".GitHub has no field or method CreateReview)
test / Unit testing: internal/engine/eval/vulncheck/review.go#L408
ra.cli.DismissReview undefined (type "github.com/mindersec/minder/pkg/providers/v1".GitHub has no field or method DismissReview)
test / Unit testing: internal/providers/github/mock/fixtures/github.go#L62
mock.EXPECT().GetPullRequest undefined (type *mock_github.MockGitHubMockRecorder has no field or method GetPullRequest)
test / Unit testing: internal/engine/actions/alert/pull_request_comment/pull_request_comment_test.go#L50
mockGitHub.EXPECT().CreateReview undefined (type *mock_github.MockGitHubMockRecorder has no field or method CreateReview)
test / Unit testing: internal/engine/actions/alert/pull_request_comment/pull_request_comment_test.go#L61
mockGitHub.EXPECT().CreateReview undefined (type *mock_github.MockGitHubMockRecorder has no field or method CreateReview)
license-check / License boilerplate check
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
build / Verify build
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
compose-migrate / docker
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
image-build / Check docker image build
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
lint / Run golangci-lint
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
image-build / Build Helm chart
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
image-build / Image build
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
test / Authz tests
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
lint / Uncommitted changes check - go mod tidy & make gen
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
test / Unit testing
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Artifacts

Produced during runtime
Name Size
mindersec~minder~Q6XROJ.dockerbuild
21.2 KB