Allow empty version to be the same as v1 in providers (#5172)

mindersec · Dec 11, 2024 · 9336b1b · 9336b1b
1 parent 7d818e9
commit 9336b1b
Show file tree

Hide file tree

Showing 5 changed files with 1,081 additions and 1,070 deletions.
diff --git a/docs/docs/ref/proto.md b/docs/docs/ref/proto.md
diff --git a/internal/controlplane/handlers_providers.go b/internal/controlplane/handlers_providers.go
@@ -39,6 +39,10 @@ func (s *Server) CreateProvider(
 		return nil, status.Errorf(codes.InvalidArgument, "provider is required")
 	}
 
+	if provider.GetVersion() == "" {
+		provider.Version = "v1"
+	}
+
 	var provConfig json.RawMessage
 	if provider.Config != nil {
 		var marshallErr error
@@ -237,6 +241,10 @@ func (s *Server) PatchProvider(
 		return nil, status.Errorf(codes.InvalidArgument, "provider name is required")
 	}
 
+	if req.GetPatch() != nil && req.GetPatch().GetVersion() == "" {
+		req.Patch.Version = "v1"
+	}
+
 	err := s.providerManager.PatchProviderConfig(ctx, providerName, projectID, req.GetPatch().GetConfig().AsMap())
 	if err != nil {
 		if errors.Is(err, sql.ErrNoRows) {

diff --git a/pkg/api/openapi/minder/v1/minder.swagger.json b/pkg/api/openapi/minder/v1/minder.swagger.json