Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump buf.build/gen/go/bufbuild/protovalidate/protocolbuffers/go from 1.35.2-20240920164238-5a7b106cbb87.1 to 1.35.2-20241127180247-a33202765966.1 #5070

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 28, 2024

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from a team as a code owner November 28, 2024 06:32
@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Nov 28, 2024
@eleftherias
Copy link
Contributor

Looking into a fix

@eleftherias eleftherias mentioned this pull request Nov 28, 2024
10 tasks
@eleftherias
Copy link
Contributor

It seems the library deprecated a field but hasn't started populating the replacement yet. I will report upstream once I have a minimal sample.

Copy link
Contributor

@eleftherias eleftherias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking the merge

Copy link
Contributor

@eleftherias eleftherias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems we should wait on bufbuild/protovalidate-go#154 to be merged and a new version of protovalidate-go.

@dependabot dependabot bot force-pushed the dependabot/go_modules/buf.build/gen/go/bufbuild/protovalidate/protocolbuffers/go-1.35.2-20241127180247-a33202765966.1 branch from 2906a79 to d5016fc Compare December 6, 2024 08:12
@coveralls
Copy link

coveralls commented Dec 6, 2024

Coverage Status

coverage: 55.349% (+0.004%) from 55.345%
when pulling fd3d38d on dependabot/go_modules/buf.build/gen/go/bufbuild/protovalidate/protocolbuffers/go-1.35.2-20241127180247-a33202765966.1
into b69d87d on main.

@eleftherias
Copy link
Contributor

@dependabot rebase

…fers/go

---
updated-dependencies:
- dependency-name: buf.build/gen/go/bufbuild/protovalidate/protocolbuffers/go
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/go_modules/buf.build/gen/go/bufbuild/protovalidate/protocolbuffers/go-1.35.2-20241127180247-a33202765966.1 branch from d5016fc to fd3d38d Compare December 12, 2024 16:45
…ild/protovalidate/protocolbuffers/go-1.35.2-20241127180247-a33202765966.1
}
return strings.Join(res, "\n")
}

func getFullPath(field *validate.FieldPath) string {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a smarter way to do this?

Copy link
Contributor

@eleftherias eleftherias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ready for a review from someone else now

@eleftherias eleftherias merged commit ee82c4b into main Dec 13, 2024
24 of 25 checks passed
@eleftherias eleftherias deleted the dependabot/go_modules/buf.build/gen/go/bufbuild/protovalidate/protocolbuffers/go-1.35.2-20241127180247-a33202765966.1 branch December 13, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants