fix: Prevent using simplexml_load_file() on missing file

mindkomm · Aug 19, 2024 · fa59ded · fa59ded
1 parent 59b1f82
commit fa59ded
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/lib/Helper.php b/lib/Helper.php
@@ -496,6 +496,10 @@ public static function get_mime_types() {
 	 * @return array|null
 	 */
 	public static function get_svg_dimensions( $svg ) {
+        if ( ! file_exists( $svg ) ) {
+            return null;
+        }
+
 		$svg    = simplexml_load_file( $svg );
 		$width  = 0;
 		$height = 0;

diff --git a/lib/Image.php b/lib/Image.php
@@ -76,7 +76,7 @@ class Image {
 	 *
 	 * @var array
 	 */
-	protected $svg_dimensions = [];
+	protected array $svg_dimensions = [];
 
 	final protected function __construct() {
 	}
@@ -991,7 +991,7 @@ public function description() {
 	 */
 	public function svg_dimensions() {
 		if ( empty( $this->svg_dimensions ) ) {
-			$this->svg_dimensions = Helper::get_svg_dimensions( $this->path() );
+			$this->svg_dimensions = Helper::get_svg_dimensions( $this->path() ) ?: [];
 		}
 
 		return $this->svg_dimensions;