Merge pull request #54 from mindvalley/chore/use-github-sha-everywhere

Use github sha instead of ref name
mindvalley · Sep 6, 2024 · 14cc570 · 14cc570
2 parents df55d37 + f25f5ee
commit 14cc570
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/.github/workflows/gar-build-push-backend-container-on-tag.yml b/.github/workflows/gar-build-push-backend-container-on-tag.yml
@@ -45,7 +45,7 @@ jobs:
         id: metadata
         with:
           images: |
-            us-docker.pkg.dev/${{ env.GarProjectID }}/${{ env.GarRepo }}/${{ env.GarImageName }}:${{ github.ref_name }}
+            us-docker.pkg.dev/${{ env.GarProjectID }}/${{ env.GarRepo }}/${{ env.GarImageName }}:${{ github.sha }}
 
       - name: Backend Image Docker Build and Push
         uses: int128/kaniko-action@v1
@@ -60,7 +60,7 @@ jobs:
             --snapshot-mode=redo
             --cache-ttl=730h
           tags: |
-            us-docker.pkg.dev/${{ env.GarProjectID }}/${{ env.GarRepo }}/${{ env.GarImageName }}:${{ github.ref_name }}
+            us-docker.pkg.dev/${{ env.GarProjectID }}/${{ env.GarRepo }}/${{ env.GarImageName }}:${{ github.sha }}
             us-docker.pkg.dev/${{ env.GarProjectID }}/${{ env.GarRepo }}/${{ env.GarImageName }}:latest
           build-args: |
-            DANSWER_VERSION=${{ github.ref_name }}
+            DANSWER_VERSION=${{ github.sha }}
diff --git a/.github/workflows/gar-build-push-web-container-on-tag.yml b/.github/workflows/gar-build-push-web-container-on-tag.yml
@@ -45,7 +45,7 @@ jobs:
         id: metadata
         with:
           images: |
-            us-docker.pkg.dev/${{ env.GarProjectID }}/${{ env.GarRepo }}/${{ env.GarImageName }}:${{ github.ref_name }}
+            us-docker.pkg.dev/${{ env.GarProjectID }}/${{ env.GarRepo }}/${{ env.GarImageName }}:${{ github.sha }}
 
       - name: Web Image Docker Build and Push
         uses: int128/kaniko-action@v1
@@ -60,7 +60,7 @@ jobs:
             --snapshot-mode=redo
             --cache-ttl=730h
           tags: |
-            us-docker.pkg.dev/${{ env.GarProjectID }}/${{ env.GarRepo }}/${{ env.GarImageName }}:${{ github.ref_name }}
+            us-docker.pkg.dev/${{ env.GarProjectID }}/${{ env.GarRepo }}/${{ env.GarImageName }}:${{ github.sha }}
             us-docker.pkg.dev/${{ env.GarProjectID }}/${{ env.GarRepo }}/${{ env.GarImageName }}:latest
           build-args: |
-            DANSWER_VERSION=${{ github.ref_name }}
+            DANSWER_VERSION=${{ github.sha }}