changed plugin channel to lowercase (fix #67) #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tianji1993
approved these changes
Dec 16, 2019
|
Is there any reason this hasn't been merged? I've had to manually build this version to use it to resolve the 1.14.2 issue. |
Open
Closed
|
Any chance to get this merged? There are now multiple pull requests and issues regarding this one line of code.. |
|
RedisBungee is not maintained and will never be maintained. As the original author, I respectfully request people stop using it. |
|
https://github.com/MacacoLew/RedisBungee/ Contains all open pull requests commits |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#67 changed the capitalization of the plugin channel to work with 1.14.2.
This PR adjusts the capitalization in another class, that the original pr missed.
This might be the cause for the spigot review https://www.spigotmc.org/resources/redisbungee.13494/reviews#review-281998-172302 by luffy1025.