Optimize item checking code for throwing into trash can #19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR optimizes the codes handling throwing items into wooden trash cans.
__builtin:item
entities will be checked on EACH global step, regardless of whether they are inside a trash can__builtin:item
if any.Under normal circumstances, the number of entities inside trash cans (even after counting non-items) would be less than the number of dropped items coexisting in the world (unless a group of fools decided to stand inside trash cans forever). Therefore, this mod optimizes the runtime load.
This PR is optimized in commit 3322a30 using node timers (set up when placing a trash can or loading an old one for the first time) instead of ABM (scanning all nodes every run).
This PR is tested and ready for review. Here is the footage of the testing:
Video_2024-03-04_07-22-05.mp4