fix: load icon from site URL instead of feed URL #2957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabe565
force-pushed
the
fix-feed-icon-url
branch
from
b35250d
to
7b23bf1
Compare
gabe565
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When force refreshing, feed icons get downloaded from the feed URL instead of the site URL. This is fine in most cases, but for any feeds that use an RSS generation service like RSS-Bridge, RSSHub, or one I built called Transsmute, the feed generator's icon will be downloaded instead of the actual website icon. This PR fixes this behavior by using the site URL.
Related to #2871
Fixes #2955
Do you follow the guidelines?