Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade gensim to v4 #19

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

dcferreira
Copy link

I'm using this package with some other code I had, which was already using gensim v4, so I thought I'd upgrade it.

I tested manually by running the commands in the README and everything seemed to be working.
But there are no tests, so it's hard to be completely sure I didn't break something.

This PR just upgrades the required versions of some packages, and changes the code to use the gensim v4 API instead of v3.
I followed this guide to do the upgrade: https://github.com/RaRe-Technologies/gensim/wiki/Migrating-from-Gensim-3.x-to-4

@akb89
Copy link
Collaborator

akb89 commented Sep 30, 2022

Hi @dcferreira,
Thank you for the pull request!
I am working on something else at the moment so I cannot fully check it, but as soon as I have time I will take a look at it and merge it with master if everything works fine.
Meanwhile, I'm gonna leave this open here not to forget.
Thanks again!
Alex

@dcferreira
Copy link
Author

Hey @akb89!

I've stopped working on this in the meanwhile, but for a while I was trying to run nonce2vec on bigger datasets, and so was trying to make it faster (in the end I didn't manage to make it fast enough, so dropped the idea).
If you're interested, you can have a look at my branch: https://github.com/dcferreira/nonce2vec/tree/optimize
These are the major changes:

  • Multiple nonces are added at once, instead of one at a time
  • Added some tests for correctness
  • "Modernized" the repo by using the new pyproject.toml file and hatch

I didn't submit a PR as it is, because my main.py is not complete, but if you're interested in this I can spend some more time bringing it up to par with the main.py of the main repo.

@akb89
Copy link
Collaborator

akb89 commented Oct 24, 2022

Ok! I won't be able to take a look at this within the next 6months at least but I'll make sure to take a look as soon as I can.
Thanks again!

@akb89 akb89 self-requested a review October 24, 2022 06:48
@akb89 akb89 self-assigned this Oct 24, 2022
@akb89 akb89 modified the milestones: v3.0, v3 Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants