-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
readme: add description of ECMAScript #62
Conversation
- also add examples
@ljharb @shadowspawn |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Thanks for working through our various comments @unikounio |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #62 +/- ##
=======================================
Coverage 98.78% 98.78%
=======================================
Files 1 1
Lines 165 165
Branches 70 70
=======================================
Hits 163 163
Misses 2 2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there :-)
@ljharb |
Urk. Failing a couple of lint tests due to using "new" features in the example code ( My first thought is examples using modern syntax are more appropriate and useful for new users. Is it appropriate to add an override to Do you already have a preferred way of approaching this @ljharb ? |
yep! add an "overrides" object for |
Are you happy to look at this @unikounio , or would you like a hand with the eslint change? (Fairly easy hopefully, but depending on what you already know and what you are interested in learning...) |
@shadowspawn |
Include in this PR thanks. |
Just pushed the changes to apply the latest ESLint config to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rebased and squashed to one commit, and fixed formatting (and examples → example in eslintrc)
this LGTM and can be ff-merged once @shadowspawn concurs :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Thank you both so much for helping me with this PR! |
Added a description of ECMEScript to the readme and adjust the sample files to match.
Issue
Docs: Add sample code ES Modules format to the examples in the README. · Issue #61 · minimistjs/minimist