Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⬆️ Upgrade Jupyter image #76

Merged
merged 18 commits into from
Jan 29, 2024
Merged

⬆️ Upgrade Jupyter image #76

merged 18 commits into from
Jan 29, 2024

Conversation

jacobwoffenden
Copy link
Member

@jacobwoffenden jacobwoffenden commented Jan 19, 2024 •
edited
Loading

This pull request:

  • Is part of ⬆️ Upgrade JupyterLab to support Python >3.10 analytical-platform#2348
  • Replaces InSpec 🤮 with Google's Container Structure Test
  • Splits out build and testing from publish
  • No longer publishes to ECR, instead GHCR
  • Updates Dockerfiles to be a lot nicer
  • Updates allspark to 3.5.0
  • Updates datascience to 4.0.11
  • Removes all unused files
  • Retires oracle datascience notebook

@jacobwoffenden
Update to spark-3.5.0
2891240 
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
@jacobwoffenden jacobwoffenden self-assigned this Jan 19, 2024
@jacobwoffenden
Update Makefile
7d1d074 
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
@jacobwoffenden
Wrapping image
4573e03 
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
@jacobwoffenden
Revert compose changes <insert crying emoji>
7cc16ee 
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
@jacobwoffenden
DEBUG
a8bd3cc 
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
@jacobwoffenden
more DEBUG
f7adf36 
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
@jacobwoffenden
ever more DEBIUG
a67015c 
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
@jacobwoffenden
Switch to Chef v5
97a16ca 
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
@jacobwoffenden
Use InSpec OS license
0467e8f 
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
@jacobwoffenden
Migrate to CTT
01cd858 
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
@jacobwoffenden
fix yamllint
4d80ded 
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
@jacobwoffenden
Update Dockerfile and build script
284046c 
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
@jacobwoffenden
newlines
f0c93d5 
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
@jacobwoffenden
Update datascience-notebook
ff792ea 
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
@jacobwoffenden
Retire Oracle
7bfcfca 
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
@jacobwoffenden
Rename build and test
2430d53 
Add publish

Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
@jacobwoffenden
yaml lint
33a9a2c 
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
@jacobwoffenden jacobwoffenden marked this pull request as ready for review January 29, 2024 16:23
@jacobwoffenden
Bump all spark to 4.0.11
a1d246c 
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
michaeljcollinsuk
michaeljcollinsuk approved these changes Jan 29, 2024
View reviewed changes
Copy link

@michaeljcollinsuk michaeljcollinsuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jacobwoffenden jacobwoffenden merged commit 26a21c0 into main Jan 29, 2024
4 checks passed
@jacobwoffenden jacobwoffenden deleted the feature/python-upgrade branch January 29, 2024 17:22
@jacobwoffenden jacobwoffenden mentioned this pull request Jan 29, 2024
Closed
6 tasks
@michaeljcollinsuk michaeljcollinsuk mentioned this pull request Jul 1, 2024
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaeljcollinsuk michaeljcollinsuk michaeljcollinsuk approved these changes

Assignees

@jacobwoffenden jacobwoffenden

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacobwoffenden @michaeljcollinsuk