Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use IRSA for JPC reports #2164

Merged
merged 3 commits into from
Sep 7, 2023
Merged

fix: Use IRSA for JPC reports #2164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6ddf7d5
fix: Use IRSA for JPS reports
jimbali Sep 7, 2023
5b0ba2b
fix: Stop checking for secret access ID & key in metrics task
jimbali Sep 7, 2023
b4f0799
chore: Delete old migrate job
jimbali Sep 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions app/lib/cloud_data/reports_feed.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,7 @@
module CloudData
class ReportsFeed
def initialize(bucket_name = ENV['S3_REPORTING_BUCKET_NAME'])
client = Aws::S3::Client.new(
access_key_id: ENV['S3_REPORTING_ACCESS_KEY_ID'],
secret_access_key: ENV['S3_REPORTING_SECRET_ACCESS_KEY'],
)
client = Aws::S3::Client.new
@s3 = Aws::S3::Resource.new(client: client)
@bucket = @s3.bucket(bucket_name)
end
Expand Down
45 changes: 0 additions & 45 deletions k8s_migrate_job.yml
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions lib/tasks/metrics.rake
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
namespace :metrics do
desc 'Exports metrics in all the popular formats to s3'
task :export, [:metric_class] => :environment do |_, args|
abort 'Please set S3_METRICS_ACCESS_KEY_ID' if ENV['S3_METRICS_ACCESS_KEY_ID'].blank?
abort 'Please set S3_METRICS_SECRET_ACCESS_KEY' if ENV['S3_METRICS_SECRET_ACCESS_KEY'].blank?
abort 'Please set S3_METRICS_REGION' if ENV['S3_METRICS_REGION'].blank?
abort 'Please set S3_METRICS_BUCKET_NAME' if ENV['S3_METRICS_BUCKET_NAME'].blank?

Expand Down