This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
SDIT-1113: 🔒️ Secure automated refresh endpoint and test #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petergphillips
force-pushed
the
pgp-SDIT-1113-secure-automated-refresh
branch
from
3206cc5
to
9c36e36
Compare
mikehalmamoj
reviewed
Oct 6, 2023
Comment on lines
+50
to
+58
| testClazz.memberFunctions | ||
| .filter { it.name.contains("access forbidden") } | ||
| .map { | ||
| it.name | ||
| .substringAfter("for endpoint ") | ||
| .substringBefore(" when no role") | ||
| .replace("#", "/") | ||
| } | ||
| } |
There was a problem hiding this comment.
Not keen on this - for all I know the test has the right name but tests something entirely different. Not sure of a better way though 🤔
There was a problem hiding this comment.
Agreed. Ideally though wouldn't be needed at all since the resources will have the annotations. However didn't want to start changing this project since we're in the process of ripping it all out anyway.
There was a problem hiding this comment.
I think it would still be relevant for Prison API though
steverendell
approved these changes
Oct 6, 2023
| mapping.handlerMethods.forEach { (mappingInfo, method) -> | ||
| val classAnnotation = method.beanType.getAnnotation(PreAuthorize::class.java) | ||
| val annotation = method.getMethodAnnotation(PreAuthorize::class.java) | ||
| println("Found $mappingInfo with class annotation $classAnnotation and annotation $annotation") |
There was a problem hiding this comment.
was this line a temporary data dump?
There was a problem hiding this comment.
yes it was, will remove in next PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.