Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add footer #32

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add footer #32

wants to merge 2 commits into from

Conversation

z-vr
Copy link
Contributor

@z-vr z-vr commented Jun 8, 2017

This PR adds a footer. Could be useful to put something like loading indicator.

@z-vr z-vr force-pushed the feature/footer-text branch from dd2c5b6 to 20c0d01 Compare June 8, 2017 11:08
@tbleckert
Copy link
Contributor

I'm sorry, I've totally missed this one. I like it, good feature, can be really useful. Is it possible for me to contribute to your PR (have never done it before)? Or do you have time to make it compatible with the latest updates/code changes?

Either way, thanks!

@z-vr z-vr force-pushed the feature/footer-text branch 2 times, most recently from a0fefd3 to b0b74b2 Compare December 7, 2017 15:39
@z-vr
Copy link
Contributor Author

z-vr commented Dec 7, 2017

@tbleckert hey I've updated the PR -- you'll have to rebuild the dist though!

@tbleckert
Copy link
Contributor

Awesome, thanks!

@tbleckert
Copy link
Contributor

What do you think about making the footer a separate layer below the buttons? Something like this

Title
Body
Buttons
Footer

Just an idea I got and wanted to hear your opinion about it.

@z-vr z-vr force-pushed the feature/footer-text branch from b0b74b2 to d29c1cd Compare January 11, 2018 12:59
@z-vr
Copy link
Contributor Author

z-vr commented Jan 11, 2018

@tbleckert hey, the way we use it is to place a loading indicator in there, e.g.,
jan-11-2018 13-04-39
I feel like if there appears an extra area below the button, it would make the form jump if you get what i mean? It's probably possible to configure this kind of footer as you mentioned because it does look cool on the image above.

@tbleckert
Copy link
Contributor

Ah ok I see. What do you think about having the buttons arrays accepting components as well (not only button objects)?

{
    left: [<LoadingIndicator />],
    right: [{
        text: 'Add',
    }]
}

That way you also get more freedom when it comes to adding buttons.

And then skip the footer idea I had or have it as a second new feature.

@z-vr z-vr force-pushed the feature/footer-text branch from d29c1cd to bd36bb7 Compare January 23, 2018 13:15
@tbleckert tbleckert added this to the v1.0.0 milestone Jan 30, 2018
@tbleckert
Copy link
Contributor

tbleckert commented May 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants