-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add footer #32
base: master
Are you sure you want to change the base?
add footer #32
Conversation
I'm sorry, I've totally missed this one. I like it, good feature, can be really useful. Is it possible for me to contribute to your PR (have never done it before)? Or do you have time to make it compatible with the latest updates/code changes? Either way, thanks! |
a0fefd3
to
b0b74b2
Compare
@tbleckert hey I've updated the PR -- you'll have to rebuild the |
Awesome, thanks! |
b0b74b2
to
d29c1cd
Compare
@tbleckert hey, the way we use it is to place a loading indicator in there, e.g., |
Ah ok I see. What do you think about having the buttons arrays accepting components as well (not only button objects)? {
left: [<LoadingIndicator />],
right: [{
text: 'Add',
}]
} That way you also get more freedom when it comes to adding buttons. And then skip the footer idea I had or have it as a second new feature. |
d29c1cd
to
bd36bb7
Compare
@z-vr Would this suit your needs? https://github.com/minutemailer/react-popup/blob/master/example/index.jsx#L19-L29 |
This PR adds a footer. Could be useful to put something like loading indicator.