Multiple cutoffs for B1 and B3 #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add multiple cutoff support for b1 and b3, previously it was only supported in b2.
ace_binding.cpp: add python interface support of b1/b3 multiple cutoffsb1.h,b1.cpp,b3.h: add init functions to allow input of a cutoff matrixb3.cpp: changecomplex_single_bondtocomplex_single_bond_multiple_cutoffs, such that multiple cutoffs are allowed. The modification is the same as our b2 codeb3.cpp: addwrite_to_fileto allow writing lammps coefficients header for b3 (although we don't include b3 lammps code in this PR)