Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: added nullaway #177

Merged
merged 3 commits into from
Nov 5, 2024
Merged

build: added nullaway #177

merged 3 commits into from
Nov 5, 2024

Conversation

chgl
Copy link
Contributor

@chgl chgl commented Oct 29, 2024

No description provided.

Copy link

github-actions bot commented Oct 29, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 4 0 0.04s
✅ DOCKERFILE hadolint 2 0 0.08s
✅ EDITORCONFIG editorconfig-checker 67 0 0.24s
✅ GROOVY npm-groovy-lint 2 0 10.13s
✅ JAVA checkstyle 19 0 4.66s
✅ JSON jsonlint 5 0 0.18s
✅ JSON prettier 5 0 1.88s
✅ JSON v8r 5 0 4.26s
✅ MARKDOWN markdownlint 2 0 0.43s
✅ PYTHON bandit 1 0 1.1s
✅ PYTHON black 1 0 1.77s
✅ PYTHON flake8 1 0 1.44s
✅ PYTHON isort 1 0 0.34s
✅ PYTHON mypy 1 0 8.05s
✅ PYTHON ruff 1 0 0.02s
✅ REPOSITORY checkov yes no 21.41s
✅ REPOSITORY gitleaks yes no 0.71s
✅ REPOSITORY git_diff yes no 0.03s
✅ REPOSITORY grype yes no 13.67s
✅ REPOSITORY kics yes no 4.63s
✅ REPOSITORY secretlint yes no 0.89s
✅ REPOSITORY syft yes no 2.3s
✅ REPOSITORY trivy yes no 6.15s
✅ REPOSITORY trivy-sbom yes no 1.0s
✅ REPOSITORY trufflehog yes no 3.03s
✅ XML xmllint 1 0 0.01s
✅ YAML prettier 17 0 0.86s
✅ YAML yamllint 17 0 0.73s

See detailed report in MegaLinter reports

You could have same capabilities but better runtime performances if you request a new MegaLinter flavor.

MegaLinter is graciously provided by OX Security

@makampf makampf self-requested a review October 30, 2024 10:27
Copy link
Member

@makampf makampf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Insgesamt schlägt die Kompilierung mit Nullaway an 9 Stellen fehl, z.B.:

/Users/marvin/git/fhir-gateway/src/main/java/org/miracum/etl/fhirgateway/FhirSystemsConfig.java:10: Fehler: [NullAway] @NonNull field loinc not initialized
  private String loinc;
                 ^
    (see http://t.uber.com/nullaway )

build.gradle Outdated Show resolved Hide resolved
@chgl chgl requested a review from makampf November 4, 2024 16:20
Copy link

sonarqubecloud bot commented Nov 4, 2024

Copy link

github-actions bot commented Nov 4, 2024

Code Coverage Report

Overall Project 29.93% -2.92%
Files changed 0%

File Coverage
FhirSystemsConfig.java 72.73% 🍏
KafkaProcessor.java 16.33% -5.44%
BaseKafkaProcessor.java 11.22% 🍏
LoincHarmonizer.java 10.15% -11.17%
LoincConversion.java 0% 🍏

Copy link

github-actions bot commented Nov 4, 2024

Trivy image scan report

ghcr.io/miracum/fhir-gateway:pr-177 (debian 12.7)

No Vulnerabilities found

No Misconfigurations found

Java

4 known vulnerabilities found (MEDIUM: 1 LOW: 0 CRITICAL: 0 HIGH: 3)

Show detailed table of vulnerabilities
Package ID Severity Installed Version Fixed Version
ca.uhn.hapi.fhir:org.hl7.fhir.r4 CVE-2024-45294 HIGH 6.1.2.2 6.3.23
ca.uhn.hapi.fhir:org.hl7.fhir.utilities CVE-2024-45294 HIGH 6.1.2.2 6.3.23
commons-io:commons-io CVE-2024-47554 HIGH 2.11.0 2.14.0
org.springframework:spring-context CVE-2024-38820 MEDIUM 6.1.13 6.1.14, 6.0.25, 5.3.41, 6.2.0-RC2

No Misconfigurations found

@makampf makampf merged commit 14949f0 into master Nov 5, 2024
16 checks passed
@makampf makampf deleted the test-nullaway branch November 5, 2024 11:08
miracum-bot pushed a commit that referenced this pull request Nov 5, 2024
## [3.14.1](v3.14.0...v3.14.1) (2024-11-05)

### Build

* added nullaway ([#177](#177)) ([14949f0](14949f0))
@miracum-bot
Copy link

🎉 This PR is included in version 3.14.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants