Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the emoji version 15.0 to emoji-mart/data #844

Merged
merged 5 commits into from
Jan 6, 2024

Conversation

vemonet
Copy link
Contributor

@vemonet vemonet commented Jul 11, 2023

Hi @EtienneLem I upgraded the dependencies in the emoji-mart/data package.json, added version 15 to the list of emojis versions built, and run the build to add emoji version 15.0 to the package

It adds a few new emojis like 🫎 🪿 🫏: https://emojipedia.org/emoji-15.0/

Thanks a lot

Copy link

@gomjellie gomjellie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following codes need to be changed:

value: 14,
choices: [1, 2, 3, 4, 5, 11, 12, 12.1, 13, 13.1, 14],

-    value: 14,
-    choices: [1, 2, 3, 4, 5, 11, 12, 12.1, 13, 13.1, 14],
+    value: 15,
+    choices: [1, 2, 3, 4, 5, 11, 12, 12.1, 13, 13.1, 14, 15],

const VERSIONS = [
{ v: 14, emoji: '🫠' },
{ v: 13.1, emoji: '😶‍🌫️' },

const VERSIONS = [
+  { v: 15, emoji: '🫨' },
  { v: 14, emoji: '🫠' },

wish this PR be merged quickly 😄

@marlon12796
Copy link

Why didn't it merge?

@kainosnoema
Copy link

@vemonet @gomjellie can this be wrapped up and released? Seems like this project may have been abandoned?

@vemonet
Copy link
Contributor Author

vemonet commented Jan 5, 2024

@kainosnoema a month ago I sent an email to Missive, the company responsible for this repo, to ask them about their plan for the future. I did not get an answer yet

This repository is used by many projects, and it is in a pretty good shape, it would be a shame to let it go to waste.

On my fork I have added some scripts to easily update emojis to newer versions, it should not be hard to maintain

I don't have much time right now, but I am considering to create a maintained fork later this year if nothing has changed, let me know if you would be interested in helping!

@EtienneLem EtienneLem merged commit fa61247 into missive:main Jan 6, 2024
2 checks passed
@EtienneLem
Copy link
Member

Sorry for the delay; thanks for submitting the PR @vemonet 🤘🏼

@forresto
Copy link

forresto commented Jan 9, 2024

15 doesn't show as an option here yet, FYI https://missiveapp.com/open/emoji-mart

@eggplants
Copy link

emojiVersion Choices and Description in Options / Props section have to be updated.

| **emojiVersion** | `14` | `1`, `2`, `3`, `4`, `5`, `11`, `12`, `12.1`, `13`, `13.1`, `14` | The version of the emoji data to use. Latest version supported in `@emoji-mart/data` is currently [14](https://emojipedia.org/emoji-14.0) |

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants