feat: 新カスタム絵文字管理画面（β）の追加 #13473
Open
feat: 新カスタム絵文字管理画面（β）の追加 #13473
+7,423
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # packages/misskey-js/src/api.types.ts # packages/misskey-js/src/autogen/apiClientJSDoc.ts # packages/misskey-js/src/autogen/endpoint.ts # packages/misskey-js/src/autogen/entities.ts # packages/misskey-js/src/autogen/models.ts # packages/misskey-js/src/autogen/types.ts
# Conflicts: # packages/frontend/package.json # packages/misskey-js/src/autogen/apiClientJSDoc.ts # packages/misskey-js/src/autogen/endpoint.ts # packages/misskey-js/src/autogen/entities.ts # packages/misskey-js/src/autogen/models.ts # packages/misskey-js/src/autogen/types.ts # pnpm-lock.yaml
# Conflicts: # packages/misskey-js/src/autogen/apiClientJSDoc.ts # packages/misskey-js/src/autogen/endpoint.ts # packages/misskey-js/src/autogen/entities.ts # packages/misskey-js/src/autogen/models.ts # packages/misskey-js/src/autogen/types.ts
# Conflicts: # packages/backend/src/core/CustomEmojiService.ts # packages/backend/src/server/api/endpoints/admin/emoji/update.ts # packages/frontend/src/components/global/MkStickyContainer.vue
fruitriin
added a commit
to mistems/mistems
that referenced
this pull request
Nov 17, 2024
fruitriin
added a commit
to mistems/mistems
that referenced
this pull request
Nov 17, 2024
fruitriin
added a commit
to mistems/mistems
that referenced
this pull request
Nov 22, 2024
fruitriin
added a commit
to mistems/mistems
that referenced
this pull request
Nov 22, 2024
fruitriin
added a commit
to mistems/mistems
that referenced
this pull request
Nov 22, 2024
fruitriin
added a commit
to mistems/mistems
that referenced
this pull request
Nov 22, 2024
fruitriin
added a commit
to mistems/mistems
that referenced
this pull request
Nov 22, 2024
fruitriin
added a commit
to mistems/mistems
that referenced
this pull request
Nov 22, 2024
fruitriin
added a commit
to mistems/mistems
that referenced
this pull request
Nov 22, 2024
fruitriin
added a commit
to mistems/mistems
that referenced
this pull request
Nov 22, 2024
fruitriin
added a commit
to mistems/mistems
that referenced
this pull request
Dec 3, 2024
5 tasks
|
Check Misskey JS autogenのCIがコケているのは、空白が1行無くて差分が発生しているからという理由っぽいです… |
anatawa12
reviewed
Dec 29, 2024
Comment on lines
+598
to
+600
| const direction = sortKey.startsWith('-') ? 'DESC' : 'ASC'; | ||
| const key = sortKey.replace(/^[+-]/, ''); | ||
| builder.addOrderBy(`emoji.${key}`, direction); |
There was a problem hiding this comment.
copied from niri-la#239 (comment)
未知のsortKeyでSQL Injectionできないかが若干こわいのでfetchEmojisSortKeysにsortKeyがあるかどうかをここでも確認したい気がする
もちろん API の json validation で弾いてるっぽいけど、念のためにここで確認したくなる
(将来別のAPI等が使うようになった際に API 側の実装を忘れる可能性を気にしてる)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
カスタム絵文字の登録画面をリニューアルし、複数の絵文字に対して同時に登録・更新作業を行えるようにしました。
Why
resolve #10996
Additional info (optional)
既存のカスタム絵文字管理画面はそのままのこし、新画面はβ版の位置づけで追加しています（安定したら完全に置き換える考え）。
Checklist