Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(types): remove any not needed and to strict types #15157

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

EdamAme-x
Copy link
Contributor

What

必要のないanyを削除し、複数の型を厳格化

Why

型安全性の向上

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@EdamAme-x EdamAme-x changed the title refactor(types): delete any not needed refactor(types): remove any not needed Dec 20, 2024
@github-actions github-actions bot added packages/frontend Client side specific issue/PR packages/backend Server side specific issue/PR packages/backend:test labels Dec 20, 2024
@EdamAme-x EdamAme-x marked this pull request as draft December 20, 2024 06:58
Copy link
Contributor

github-actions bot commented Dec 20, 2024

このPRによるapi.jsonの差分
差分はありません。
Get diff files from Workflow Page

@EdamAme-x EdamAme-x changed the title refactor(types): remove any not needed refactor(types): remove any not needed and strict types Dec 20, 2024
@EdamAme-x EdamAme-x changed the title refactor(types): remove any not needed and strict types refactor(types): remove any not needed and to strict types Dec 20, 2024
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 17 lines in your changes missing coverage. Please review.

Project coverage is 39.95%. Comparing base (f123be3) to head (461635a).

Files with missing lines Patch % Lines
packages/backend/src/GlobalModule.ts 0.00% 3 Missing ⚠️
packages/frontend/src/scripts/misskey-api.ts 0.00% 3 Missing ⚠️
packages/backend/src/core/EmailService.ts 33.33% 2 Missing ⚠️
packages/backend/src/boot/master.ts 0.00% 1 Missing ⚠️
packages/backend/src/core/AiService.ts 50.00% 1 Missing ⚠️
packages/backend/src/core/HashtagService.ts 0.00% 1 Missing ⚠️
packages/backend/src/core/NoteCreateService.ts 75.00% 1 Missing ⚠️
packages/backend/src/core/NoteDeleteService.ts 50.00% 1 Missing ⚠️
...ckages/backend/src/core/PushNotificationService.ts 0.00% 1 Missing ⚠️
packages/backend/src/core/UserSuspendService.ts 0.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #15157      +/-   ##
===========================================
- Coverage    39.95%   39.95%   -0.01%     
===========================================
  Files         1563     1563              
  Lines       197878   197882       +4     
  Branches      3635     3634       -1     
===========================================
- Hits         79059    79054       -5     
- Misses      118215   118255      +40     
+ Partials       604      573      -31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EdamAme-x EdamAme-x marked this pull request as ready for review December 20, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend:test packages/backend Server side specific issue/PR packages/frontend Client side specific issue/PR
Projects
Development

Successfully merging this pull request may close these issues.

2 participants