Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): アカウント一覧画面で、ユーザー情報の取得に失敗したアカウントが表示されない問題を修正 #15183

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

kakkokari-gtyih
Copy link
Contributor

@kakkokari-gtyih kakkokari-gtyih commented Dec 28, 2024

What

image

Why

すでに削除されているアカウントなど、何らかの事情でユーザー情報の取得に失敗したアカウントをデバイスから削除できない問題を修正

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Dec 28, 2024
Copy link

codecov bot commented Dec 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 87 lines in your changes missing coverage. Please review.

Project coverage is 19.30%. Comparing base (3c81926) to head (9415433).

Files with missing lines Patch % Lines
packages/frontend/src/pages/settings/accounts.vue 0.00% 87 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #15183       +/-   ##
============================================
- Coverage    39.96%   19.30%   -20.66%     
============================================
  Files         1563      728      -835     
  Lines       197878   103939    -93939     
  Branches      3646      991     -2655     
============================================
- Hits         79080    20066    -59014     
+ Misses      118193    83319    -34874     
+ Partials       605      554       -51     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
Development

Successfully merging this pull request may close these issues.

1 participant