Fix(frontend): 削除して編集で引用ありを消せない #15249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #15249 +/- ##
===========================================
+ Coverage 19.94% 20.06% +0.12%
===========================================
Files 729 729
Lines 104055 104056 +1
Branches 1200 1198 -2
===========================================
+ Hits 20749 20876 +127
+ Misses 82753 82628 -125
+ Partials 553 552 -1 ☔ View full report in Codecov by Sentry. |
Sayamame-beans
approved these changes
Jan 10, 2025
|
|
with type fix
|
@Sayamame-beans changelog追加漏れの追加、非常に助かります！ ところで
これってそうなってましたっけ？ |
|
ア! |
tai-cha
commented
Jan 12, 2025
やっておきました 👍 |
|
失礼しました🙏 |
mi-gh-maintainer
bot
merged commit dd6743d
into
misskey-dev:develop
8 of 9 checks passed
|
Thank you 🙏 |
Ruruke
pushed a commit
to Ruruke/misskey
that referenced
this pull request
Jan 14, 2025
* Fix(frontend): 削除して編集で引用ありを消せない * docs(changelog): update CHANGELOG.md * rename noteToRenote -> renoteTargetNote with type fix * Update Changelog --------- Co-authored-by: Sayamame-beans <61457993+Sayamame-beans@users.noreply.github.com> Co-authored-by: syuilo <4439005+syuilo@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
削除して編集で引用を消すためにprops.renoteを直接利用せずいったん保管して消せるように
Why
Fix #14476
Close #15245
Additional info (optional)
変数名の命名が微妙な気がするのでいい代替があれば変えたい
Checklist