fix(frontend): RSSウィジェットでURLエンコードを二重に行っている問題を修正 #15272
Merged
+4
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`url.searchParams.set()` already encodes the values passed! (this is a partial revert of 0472d43, the change in `statusbar-rss.vue` was correct)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #15272 +/- ##
============================================
- Coverage 40.31% 20.06% -20.26%
============================================
Files 1564 729 -835
Lines 198083 104054 -94029
Branches 3837 1198 -2639
============================================
- Hits 79863 20875 -58988
+ Misses 117617 82627 -34990
+ Partials 603 552 -51 ☔ View full report in Codecov by Sentry. |
5 tasks
kakkokari-gtyih
changed the title
|
Thank you 🙏 |
Ruruke
pushed a commit
to Ruruke/misskey
that referenced
this pull request
Jan 14, 2025
* don't double-url-encode rss urls `url.searchParams.set()` already encodes the values passed! (this is a partial revert of 0472d43, the change in `statusbar-rss.vue` was correct) * Update Changelog --------- Co-authored-by: dakkar <dakkar@thenautilus.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
べつにバックエンドどうこうの問題ではなく
URLSearchParamsを使っているのに二重でURLエンコーディングをしているのが問題だったとみられるWhy
Fix #15014
Close #15015
Additional info (optional)
Checklist