Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: convert CEUs to decimal #3217

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

asadali145
Copy link
Contributor

@asadali145 asadali145 commented Nov 4, 2024

What are the relevant tickets?

Closes https://github.com/mitodl/hq/issues/5834

Description (What does it do?)

Converts CEUs from string to decimal to avoid issues.

How can this be tested?

  • Checkout master branch and create the data
  • Create a few certificate pages for program and course pages. Add CEUs, Keep a few CEUs empty, and override a couple.
  • Create multiple course runs and program certificates.
  • Now checkout this branch and apply the migration
  • Test the following:
    • CEUs are visible on the product page if the certificate.CEUs exist, but are not visible if only override exists without the certificate.CEUs
    • CEUs are visible in the certificate preview if the certificate.CEUs, not visible if only override
    • CEUs are visible in the certificates if CEUs exist or Override is visible when CEUs exist.
    • Credits are correct in api/courses, should be null or string
    • Credits are correct in api/programs, should be null or string for each course and null or string for the program itself
    • CEUs are visible in the dashboard receipt.
    • I am not sure about the usage of build_course_run_credential and build_program_credential, But we should verify that CEUs are returned in the data. I verified it through shell
  • Verify that nothing changes display-wise and no breaking changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants