fix: failing CI tests #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anas12091101
force-pushed
the
anas/fix-ci
branch
from
e81b595
to
c13fb8c
Compare
|
@feoh, sorry, It seems like there's some new error coming on CI when running the tests. I'll look into them and will re-label this PR |
feoh
previously approved these changes
Nov 18, 2024
feoh
approved these changes
Nov 19, 2024
Anas12091101
commented
Nov 19, 2024
run_devstack_integration_tests.sh
Outdated
There was a problem hiding this comment.
The CI was failing due to no test in recently added chat plugin. I added the conditions here to gracefully handle this case
Anas12091101
commented
Nov 19, 2024
There was a problem hiding this comment.
The edx-sysadmin tests were failing due to the removal of "import" management command from LMS in openedx/edx-platform#35851
arslanashraf7
approved these changes
Nov 22, 2024
Comment on lines
+339
to
+341
| import_cmd = importlib.import_module( | ||
| "cms.djangoapps.contentstore.management.commands.import" | ||
| ) | ||
| management.call_command( | ||
| "import", | ||
| import_cmd.Command(), |
There was a problem hiding this comment.
Maybe we can replace all this with?
management.call_command("import",
app_label="cms"
...
)
Anas12091101
force-pushed
the
anas/fix-ci
branch
2 times, most recently
from
fcc7b5e
to
c530f6b
Compare
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
Closes https://github.com/mitodl/hq/issues/6086
Description (What does it do?)
CI was failing after the merge of overhangio/tutor@a666732. This PR removes python 3.8 from CI.
Note: edx-platform is also running tests only on python 3.11
Screenshots (if appropriate):
How can this be tested?
Verify that all the checks are passing and all the tests are running
Additional Context