-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misc: Remove unnecessary assets and imports #59
Conversation
✅ Deploy Preview for parthmittal ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Don't comment files that are required. That's breaking the build
- Commit messages are written in the imperative tense. For instance, Fix loading issue instead of fixed loading issue
- Prefix each commit with something that describes its category. Here it can be misc:
- When you mention 'closes #something' in the PR description, GitHub closes that issue automatically once merged. So specify the issue in this case not the PR number.
@mittal-parth req update. |
@Brijeshthummar02 As I said earlier also, you have to remove unnecessary imports also. For instance, here import robot from "./robot.png";
import send from "./Send.svg";
import shield from "./Shield.svg";
....
export {
robot,
send,
shield,
...
} These imports are not used beyond this file meaning they are never used. How did I find that? Go through each asset that is imported in this file. Do a global search for that (like robot here) in your code editor (Ctrl + Shift + F for VSCode on Linux/Windows). If that doesnt occur beyond this file, then its not being used. In contrast some file like |
Hi @Brijeshthummar02, still working on it? |
By mistake i deleted the repo from system so i can't edit the current pr need to create new if its okayy. |
@Brijeshthummar02 you don’t have to make a new PR. Your fork still exists on GitHub. Just pull that and you are good to go |
@mittal-parth now is it ok? |
Have you checked if these are all imports to be removed? I just gave an example. Please read the entire comment again and lemme know. |
Hi @Brijeshthummar02! Let’s close this soon? |
i'm working on it. |
give me complete list of which one to remove |
There is nothing left for you to do if I do that myself. The point of the issue was to explore and get a hang of the project. I have given enough steps for you to be able to do it comfortably. If you won’t be able to pick it up, lemme know. |
issue #57
closses #58